Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2027753003:
Fix GN build for gles2_conform_test on Windows. (Closed)
|
Created:
4 years, 6 months ago by Jamie Madill Modified:
4 years, 6 months ago CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit), ericrk Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix GN build for gles2_conform_test on Windows.
Also should fix it on Mac, but untested.
BUG=616449
TBR=piman@chromium.org, sievers@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/8a208672ab14fa87cd1dd5ad6043a11c22e4d71e
Cr-Commit-Position: refs/heads/master@{#397200}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
Description was changed from ========== Fix GN build for gles2_conform_test on Windows. Also should fix it on Mac, but untested. BUG=616449 R=piman@chromium.org ========== to ========== Fix GN build for gles2_conform_test on Windows. Also should fix it on Mac, but untested. BUG=616449 R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Fix GN build for gles2_conform_test on Windows. Also should fix it on Mac, but untested. BUG=616449 R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix GN build for gles2_conform_test on Windows. Also should fix it on Mac, but untested. BUG=616449 R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
PTAL, this should also unblock moving the GPU bots to GN when necessary.
The CQ bit was checked by jmadill@chromium.org to run a CQ dry run
jmadill@chromium.org changed reviewers: + sievers@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027753003/1
PTAL sievers, didn't see piman was on vacation.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kbr@chromium.org changed reviewers: + kbr@chromium.org
lgtm fwiw.
Description was changed from ========== Fix GN build for gles2_conform_test on Windows. Also should fix it on Mac, but untested. BUG=616449 R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix GN build for gles2_conform_test on Windows. Also should fix it on Mac, but untested. BUG=616449 TBR=piman@chromium.org, sievers@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
landing TBR with the trybots
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027753003/1
Message was sent while issue was closed.
Description was changed from ========== Fix GN build for gles2_conform_test on Windows. Also should fix it on Mac, but untested. BUG=616449 TBR=piman@chromium.org, sievers@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix GN build for gles2_conform_test on Windows. Also should fix it on Mac, but untested. BUG=616449 TBR=piman@chromium.org, sievers@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix GN build for gles2_conform_test on Windows. Also should fix it on Mac, but untested. BUG=616449 TBR=piman@chromium.org, sievers@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix GN build for gles2_conform_test on Windows. Also should fix it on Mac, but untested. BUG=616449 TBR=piman@chromium.org, sievers@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/8a208672ab14fa87cd1dd5ad6043a11c22e4d71e Cr-Commit-Position: refs/heads/master@{#397200} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8a208672ab14fa87cd1dd5ad6043a11c22e4d71e Cr-Commit-Position: refs/heads/master@{#397200} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
