Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2027753002: Adding missing manifest to gn-built app_list_demo (Closed)

Created:
4 years, 6 months ago by brucedawson
Modified:
4 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, Matt Giuca, tapted
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding missing manifest to gn-built app_list_demo Many executables are missing embedded manifest files when built with gn. This causes OS compatibility information to be omitted which can lead to strange behavior. This adds a manifest to app_list_demo.exe. BUG=602505 Committed: https://crrev.com/d64a9dbc5611dcab7a850f8bbadfcc12d6e7b465 Cr-Commit-Position: refs/heads/master@{#397042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/app_list/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
brucedawson
Boilerplate change, PTAL
4 years, 6 months ago (2016-05-31 18:30:11 UTC) #2
tapted
lgtm, but CL description should say 'app_list_demo.exe', rather than it2me_standalone_host_main.exe Might be good to mention ...
4 years, 6 months ago (2016-06-01 01:02:48 UTC) #3
brucedawson
On 2016/06/01 01:02:48, tapted wrote: > lgtm, but CL description should say 'app_list_demo.exe', rather than ...
4 years, 6 months ago (2016-06-01 01:05:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027753002/1
4 years, 6 months ago (2016-06-01 01:06:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 03:31:26 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 03:33:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d64a9dbc5611dcab7a850f8bbadfcc12d6e7b465
Cr-Commit-Position: refs/heads/master@{#397042}

Powered by Google App Engine
This is Rietveld 408576698