Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2027733003: [ios Mojo] Enabled Mojo WebUI by default. (Closed)

Created:
4 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 5 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios Mojo] Enabled Mojo WebUI by default. On all platforms except iOS Mojo API is implemented natively. On iOS Chrome is not allowed to use Blink and uses WKWebView. So the only way to implement Mojo API is hybrid approach: - API frontend is implemented in JS; - frontend packs function name and arguments into JSON and sends to the native code; - window.prompt is used as communication channel, because this is the only way to send synchronous message from WKWebView; - native code will pass JSON to facade; - facade will respond with JSON; - native code will send JSON back to JS via window.prompt result; - JS frontend will unpack JSON and will return the result to the caller; This CL introduces a facade class which takes JSON as in input, passes it to Mojo and then returns the result as JSON. Design doc: https://docs.google.com/document/d/1iUJXX_zoY2BbnecpfxjznOeasf29KUzl_9S_LG08Bes/edit#heading=h.yjqp5garsqf9 BUG=567809 Committed: https://crrev.com/b0bdc55356ab6ad213553ddd32ca82dc2bebd1b7 Cr-Commit-Position: refs/heads/master@{#403864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M ios/web/web_state/ui/crw_web_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 2 chunks +1 line, -3 lines 0 comments Download
M ios/web/webui/web_ui_mojo_inttest.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027733003/1
4 years, 6 months ago (2016-06-01 05:55:48 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 06:45:04 UTC) #4
Eugene But (OOO till 7-30)
Got approval to land this after M53 branch. Please do *not* CQ if this look ...
4 years, 5 months ago (2016-06-28 00:58:27 UTC) #7
Jackie Quinn
Are we not planning on using a flag for this? A few typos in the ...
4 years, 5 months ago (2016-06-28 07:41:35 UTC) #8
Eugene But (OOO till 7-30)
Thanks! Other platforms do not use flag for this so I don't think that we ...
4 years, 5 months ago (2016-06-28 14:00:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2027733003/1
4 years, 5 months ago (2016-07-06 06:09:50 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 07:51:02 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 07:51:08 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 07:52:50 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0bdc55356ab6ad213553ddd32ca82dc2bebd1b7
Cr-Commit-Position: refs/heads/master@{#403864}

Powered by Google App Engine
This is Rietveld 408576698