Issue 202773002: Presubmit check improvements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 202773002: Presubmit check improvements. (Closed)

Created:
6 years, 9 months ago by szager1

Modified:
6 years, 9 months ago

Reviewers:
agable, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Presubmit check improvements. - Don't pylint files in .gitignore or .git/info/excludes - Print full path to modules in pylint. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=257672

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	PRESUBMIT.py	View	1	2 chunks	+13 lines, -0 lines	2 comments	Download
	M	third_party/pylint/reporters/text.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/202773002/10003

6 years, 9 months ago (2014-03-18 17:21:35 UTC) #4

M-A Ruel

6 years, 9 months ago (2014-03-18 19:29:15 UTC) #6

Message was sent while issue was closed.

IMHO, the fix would be to create a function in InputApi to get the lists of all
the files in the repo. It was not done before because svn is slow to do this,
but git ls-files is fine so it would be doable.

https://codereview.chromium.org/202773002/diff/10003/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/202773002/diff/10003/PRESUBMIT.py#newcode12
PRESUBMIT.py:12: import os
Not needed.

https://codereview.chromium.org/202773002/diff/10003/PRESUBMIT.py#newcode25
PRESUBMIT.py:25: if os.path.exists('.gitignore'):
input_api.os_path.exists

Expand Messages | Collapse Messages