Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2027723002: Rollback checking bounds of type parameters of function type aliases. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rollback checking bounds of type parameters of function type aliases. The line: List<DartType> parameterTypes = element.type.typeArguments; returns an empty list for typedefs. For now I want to unblock Keerti. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3d70bc399e08a6c3bfedbaaf7a87683746bccb72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 6 months ago (2016-05-31 17:36:35 UTC) #1
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-05-31 17:48:59 UTC) #2
scheglov
4 years, 6 months ago (2016-05-31 17:51:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3d70bc399e08a6c3bfedbaaf7a87683746bccb72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698