Support glCopyTex[Sub]Image to LUMA formats on the core profile.

Support glCopyTex[Sub]Image to LUMA formats on the core profile.

BUG=577144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b205ab6dba72592ec551d7448a8932846b4cb19d
Cr-Commit-Position: refs/heads/master@{#399545}

[Geoff Lang, 2016-05-31 20:28:49]

Description was changed from

==========
Support glCopyTex[Sub]Image to LUMA formats on the core profile.

BUG=577144
==========

to

==========
Support glCopyTex[Sub]Image to LUMA formats on the core profile.

BUG=577144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-05-31 20:31:11]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 20:31:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027703003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027703003/1

[commit-bot: I haz the power, 2016-05-31 21:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 21:52:11]

Dry run: This issue passed the CQ dry run.

[Geoff Lang, 2016-06-01 17:32:15]

Description was changed from

==========
Support glCopyTex[Sub]Image to LUMA formats on the core profile.

BUG=577144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support glCopyTex[Sub]Image to LUMA formats on the core profile.

BUG=577144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-06-01 17:32:15]

geofflang@chromium.org changed reviewers:
+ zmo@chromium.org

[Geoff Lang, 2016-06-01 17:32:51]

PTAL.  Do you think more tests are needed or is it sufficient to remove the
webgl2 suppressions?

[Geoff Lang, 2016-06-01 17:32:53]

PTAL.  Do you think more tests are needed or is it sufficient to remove the
webgl2 suppressions?

[Zhenyao Mo, 2016-06-01 18:24:18]

mostly looks good.

I think the existing conformance tests are fine without new tests.

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc (right):

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc:97: GLuint textureUniform
=
nit: texture_uniform.

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc:103:
glActiveTexture(GL_TEXTURE0);
You don't care which active texture to use, so no need to set it to 0 here, and
no need to restore it later.

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc:209:
glTexImage2D(GL_TEXTURE_2D, 0, compatability_format, width, height, 0,
You will need to glBindBuffer(GL_PIXEL_UNPACK_BUFFER, 0) first, in case a buffer
is bound and not big enough, resulting an GL error and fails all the following
operation.

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc:222:
glDisable(GL_CULL_FACE);
Should we also disable GL_DITHER?

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_copy_tex_image.h (right):

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.h:28:
CopyTexImageResourceManager(const gles2::FeatureInfo* feature_info);
explicit

[Zhenyao Mo, 2016-06-01 18:26:48]

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc (right):

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc:103:
glActiveTexture(GL_TEXTURE0);
On 2016/06/01 18:24:18, Zhenyao Mo wrote:
> You don't care which active texture to use, so no need to set it to 0 here,
and
> no need to restore it later.

Never mind, it's easier this way for RestoreTextureUnitBindings.

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc:130:
glDeleteVertexArraysOES(1, &vao_);
Although you don't intend it to be re-initialized again after destroy, but it's
better to be safer to set all these variables to 0 after deletion.

[Zhenyao Mo, 2016-06-01 18:27:01]

By the way, great work!

[Geoff Lang, 2016-06-01 20:12:18]

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc (right):

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc:97: GLuint textureUniform
=
On 2016/06/01 18:24:18, Zhenyao Mo wrote:
> nit: texture_uniform.

Done.

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc:130:
glDeleteVertexArraysOES(1, &vao_);
On 2016/06/01 18:26:48, Zhenyao Mo wrote:
> Although you don't intend it to be re-initialized again after destroy, but
it's
> better to be safer to set all these variables to 0 after deletion.

Done.

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc:209:
glTexImage2D(GL_TEXTURE_2D, 0, compatability_format, width, height, 0,
On 2016/06/01 18:24:18, Zhenyao Mo wrote:
> You will need to glBindBuffer(GL_PIXEL_UNPACK_BUFFER, 0) first, in case a
buffer
> is bound and not big enough, resulting an GL error and fails all the following
> operation.

Ah, good point, fixed.

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc:222:
glDisable(GL_CULL_FACE);
On 2016/06/01 18:24:18, Zhenyao Mo wrote:
> Should we also disable GL_DITHER?

Done.

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_copy_tex_image.h (right):

https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.h:28:
CopyTexImageResourceManager(const gles2::FeatureInfo* feature_info);
On 2016/06/01 18:24:18, Zhenyao Mo wrote:
> explicit

Done.

[Zhenyao Mo, 2016-06-01 20:21:21]

lgtm

[Geoff Lang, 2016-06-02 18:14:03]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2016-06-02 18:14:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027703003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027703003/20001

[commit-bot: I haz the power, 2016-06-02 18:19:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 18:19:39]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Geoff Lang, 2016-06-03 14:14:14]

The CQ bit was checked by geofflang@chromium.org

[Geoff Lang, 2016-06-03 14:14:15]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2027703003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-06-03 14:14:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027703003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027703003/40001

[commit-bot: I haz the power, 2016-06-03 14:22:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 14:22:29]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Geoff Lang, 2016-06-03 15:08:02]

geofflang@chromium.org changed reviewers:
+ piman@chromium.org

[Geoff Lang, 2016-06-03 15:08:34]

piman: PTAL

[piman, 2016-06-03 20:25:36]

lgtm

[Geoff Lang, 2016-06-13 17:06:56]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 17:07:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027703003/60001

[commit-bot: I haz the power, 2016-06-13 19:28:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 19:28:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Geoff Lang, 2016-06-13 19:34:10]

On 2016/06/13 19:28:54, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

All failures look like flakes.

[Geoff Lang, 2016-06-13 19:34:14]

The CQ bit was checked by geofflang@chromium.org

[Geoff Lang, 2016-06-13 19:34:15]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2027703003/#ps60001
(title: "Support glCopyTex[Sub]Image to LUMA formats on the core profile.")

[commit-bot: I haz the power, 2016-06-13 19:35:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027703003/60001

[commit-bot: I haz the power, 2016-06-13 21:24:57]

Description was changed from

==========
Support glCopyTex[Sub]Image to LUMA formats on the core profile.

BUG=577144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support glCopyTex[Sub]Image to LUMA formats on the core profile.

BUG=577144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-06-13 21:24:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-13 21:26:11]

Description was changed from

==========
Support glCopyTex[Sub]Image to LUMA formats on the core profile.

BUG=577144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support glCopyTex[Sub]Image to LUMA formats on the core profile.

BUG=577144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b205ab6dba72592ec551d7448a8932846b4cb19d
Cr-Commit-Position: refs/heads/master@{#399545}
==========

[commit-bot: I haz the power, 2016-06-13 21:26:12]

Patchset 4 (id:??) landed as
https://crrev.com/b205ab6dba72592ec551d7448a8932846b4cb19d
Cr-Commit-Position: refs/heads/master@{#399545}