Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2027703003: Support glCopyTex[Sub]Image to LUMA formats on the core profile. (Closed)

Created:
4 years, 6 months ago by Geoff Lang
Modified:
4 years, 6 months ago
Reviewers:
Zhenyao Mo, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support glCopyTex[Sub]Image to LUMA formats on the core profile. BUG=577144 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/b205ab6dba72592ec551d7448a8932846b4cb19d Cr-Commit-Position: refs/heads/master@{#399545}

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address Mo's comments #

Patch Set 3 : #

Patch Set 4 : Support glCopyTex[Sub]Image to LUMA formats on the core profile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -53 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_copy_tex_image.h View 1 1 chunk +87 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc View 1 1 chunk +273 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 12 chunks +78 lines, -17 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 3 12 chunks +45 lines, -28 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027703003/1
4 years, 6 months ago (2016-05-31 20:31:59 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 21:52:11 UTC) #5
Geoff Lang
PTAL. Do you think more tests are needed or is it sufficient to remove the ...
4 years, 6 months ago (2016-06-01 17:32:51 UTC) #8
Geoff Lang
PTAL. Do you think more tests are needed or is it sufficient to remove the ...
4 years, 6 months ago (2016-06-01 17:32:53 UTC) #9
Zhenyao Mo
mostly looks good. I think the existing conformance tests are fine without new tests. https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc ...
4 years, 6 months ago (2016-06-01 18:24:18 UTC) #10
Zhenyao Mo
https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc File gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc (right): https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc#newcode103 gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc:103: glActiveTexture(GL_TEXTURE0); On 2016/06/01 18:24:18, Zhenyao Mo wrote: > You ...
4 years, 6 months ago (2016-06-01 18:26:48 UTC) #11
Zhenyao Mo
By the way, great work!
4 years, 6 months ago (2016-06-01 18:27:01 UTC) #12
Geoff Lang
https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc File gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc (right): https://codereview.chromium.org/2027703003/diff/1/gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc#newcode97 gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc:97: GLuint textureUniform = On 2016/06/01 18:24:18, Zhenyao Mo wrote: ...
4 years, 6 months ago (2016-06-01 20:12:18 UTC) #13
Zhenyao Mo
lgtm
4 years, 6 months ago (2016-06-01 20:21:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027703003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027703003/20001
4 years, 6 months ago (2016-06-02 18:14:37 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/194061) win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, ...
4 years, 6 months ago (2016-06-02 18:19:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027703003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027703003/40001
4 years, 6 months ago (2016-06-03 14:14:31 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/194691)
4 years, 6 months ago (2016-06-03 14:22:29 UTC) #23
Geoff Lang
piman: PTAL
4 years, 6 months ago (2016-06-03 15:08:34 UTC) #25
piman
lgtm
4 years, 6 months ago (2016-06-03 20:25:36 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027703003/60001
4 years, 6 months ago (2016-06-13 17:07:17 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/238132)
4 years, 6 months ago (2016-06-13 19:28:54 UTC) #30
Geoff Lang
On 2016/06/13 19:28:54, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 6 months ago (2016-06-13 19:34:10 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027703003/60001
4 years, 6 months ago (2016-06-13 19:35:10 UTC) #34
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-13 21:24:59 UTC) #36
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 21:26:12 UTC) #38
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b205ab6dba72592ec551d7448a8932846b4cb19d
Cr-Commit-Position: refs/heads/master@{#399545}

Powered by Google App Engine
This is Rietveld 408576698