Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: ui/login/account_picker/user_pod_row.css

Issue 2027683003: Pin keyboard moved to under the user profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Rebased. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/login/account_picker/user_pod_row.css
diff --git a/ui/login/account_picker/user_pod_row.css b/ui/login/account_picker/user_pod_row.css
index dc8e1a003b5e9cca5ec857ce19f5d831a3c10262..4937ca87ca5f0eb69c20e02dc3e3de8edf57a84c 100644
--- a/ui/login/account_picker/user_pod_row.css
+++ b/ui/login/account_picker/user_pod_row.css
@@ -19,6 +19,10 @@ podrow.images-loading {
visibility: hidden;
}
+pin-keyboard {
+ display: block;
+}
+
.pod {
-webkit-tap-highlight-color: transparent;
background-color: white;
@@ -30,13 +34,33 @@ podrow.images-loading {
height: 213px;
outline: none;
position: absolute;
+ top: 0;
transform: scale3d(0.9, 0.9, 0.9);
+ transition: height 500ms ease-in-out,
+ padding 500ms ease-in-out,
+ top 500ms ease-in-out,
+ width 500ms ease-in-out;
xiyuan 2016/06/24 21:19:09 Why 500ms? Feel kind of slow. Do we have UX stampe
sammiequon 2016/06/24 22:06:39 we don't have UX stamp. 500ms was a guess.
sammiequon 2016/06/24 22:06:39 Done.
xiyuan 2016/06/24 22:13:16 180ms is better. But check with UX about all anima
width: 180px;
z-index: 0;
}
-.account-picker.flying-pods .pod {
- transition: all 180ms;
+.pod.pin-enabled {
+ height: 600px;
+ padding: 10px;
+ top: -200px !important;
+ width: 256px;
+}
+
+.pod .pin-container {
+ height: 334px;
+ position: absolute;
+ top: 276px;
+ width: 256px;
+}
+
+#account-picker {
xiyuan 2016/06/24 21:19:09 move this into screen_account_picker.css ?
sammiequon 2016/06/24 22:06:39 Done.
sammiequon 2016/06/24 22:06:39 removed.
+ height: 100%;
+ width: 100%;
}
.pod.faded {
@@ -60,12 +84,6 @@ podrow[ncolumns='6'] .pod {
.user-image-pane {
background-color: white;
- height: 160px;
- left: 10px;
- position: absolute;
- top: 10px;
- width: 160px;
- z-index: 3;
}
html[dir=rtl] .user-image-pane {
@@ -91,6 +109,15 @@ html:not([screen=login-add-user]) .pod .user-image {
max-height: 160px;
max-width: 160px;
opacity: 0.7;
+ position: absolute;
+ top: 10px;
+ transition: max-height 500ms ease-in-out,
+ max-width 500ms ease-in-out;
+}
+
+html:not([screen=login-add-user]) .pod .user-image.pin-enabled {
+ max-height: 256px;
+ max-width: 256px;
}
html:not([screen=login-add-user]) .pod.focused .user-image {
@@ -110,11 +137,16 @@ html:not([screen=login-add-user]) .pod.focused .user-image {
color: white;
display: block;
font-size: small;
- padding: 3px 0;
+ left: 10px;
position: absolute;
text-align: center;
- top: 0;
- width: 100%;
+ top: 10px;
+ transition: width 500ms ease-in-out;
+ width: 160px;
+}
+
+.pod.signed-in .signed-in-indicator.pin-enabled {
+ width: 256px;
}
.main-pane {
@@ -138,6 +170,26 @@ html[dir=rtl] .main-pane {
width: 160px;
}
+.pod.focused:not(.multiprofiles-policy-applied) .auth-container {
+ background-color: white;
+ position: absolute;
+ top: 160px;
+ width: 160px;
+}
+
+.auth-container.pin-disabled {
+ opacity: 1;
+ transition: opacity 200ms ease-in-out 500ms,
+ visibility 200ms ease-in-out 500ms;
+ visibility: visible;
+}
+
+.auth-container.pin-enabled {
+ opacity: 0;
+ transition: none;
+ visibility: hidden;
xiyuan 2016/06/24 21:19:09 Why we need to use visibility? Do we need to reser
sammiequon 2016/06/24 22:06:39 i use visibility to prevent people from tabbing to
xiyuan 2016/06/24 22:13:17 Do you need to keep the element's space while it i
sammiequon 2016/06/24 22:39:01 i think i do because the pin-keyboard is considere
xiyuan 2016/06/24 22:43:54 Okay then.
jdufault 2016/06/24 22:57:05 Add a comment noting that?
+}
+
.name-container {
transition: transform 180ms;
}

Powered by Google App Engine
This is Rietveld 408576698