Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: ui/login/resource_loader.js

Issue 2027683003: Pin keyboard moved to under the user profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fixed patch set 6 errors. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/login/resource_loader.js
diff --git a/ui/login/resource_loader.js b/ui/login/resource_loader.js
index 56a68353cf9dbf8aefbcdcaf98813a207ca0817a..d9ddeda018e9a995b21a978e89ddd636a6cf83ed 100644
--- a/ui/login/resource_loader.js
+++ b/ui/login/resource_loader.js
@@ -218,13 +218,13 @@ cr.define('cr.ui.login.ResourceLoader', function() {
*/
function waitUntilLayoutComplete(id, callback) {
var doWait = function() {
- var element = $(id);
+ var element = document.getElementsByClassName(id)[0];
jdufault 2016/06/23 00:02:31 How about this: - Rename id to selector - If sele
sammiequon 2016/06/23 19:23:21 Done.
if (!element || !element.offsetHeight) {
requestAnimationFrame(doWait);
return;
}
- callback(element);
+ callback();
jdufault 2016/06/23 00:02:32 ?
sammiequon 2016/06/23 19:23:21 Done.
};
requestAnimationFrame(doWait);

Powered by Google App Engine
This is Rietveld 408576698