Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: ui/login/account_picker/screen_account_picker.js

Issue 2027683003: Pin keyboard moved to under the user profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fixed patch set 6 errors. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/login/account_picker/screen_account_picker.js
diff --git a/ui/login/account_picker/screen_account_picker.js b/ui/login/account_picker/screen_account_picker.js
index 5d78fdc673dbcba8a2dcce7018f6c81bef8de759..e5f91e597cf8784cae36f001a6aabc7a38eb05b8 100644
--- a/ui/login/account_picker/screen_account_picker.js
+++ b/ui/login/account_picker/screen_account_picker.js
@@ -204,7 +204,7 @@ login.createScreen('AccountPickerScreen', 'account-picker', function() {
for (var i = 0; i < users.length; ++i) {
var user = users[i];
if (user.showPin) {
- showPinKeyboardAsync();
+ loadPinKeyboardAsync();
return;
}
}
@@ -216,13 +216,13 @@ login.createScreen('AccountPickerScreen', 'account-picker', function() {
* @param {boolean} showGuest Whether to show guest session button.
*/
loadUsers: function(users, showGuest) {
- this.loadPinKeyboardIfNeeded_(users);
-
- $('pod-row').loadPods(users);
$('login-header-bar').showGuestButton = showGuest;
// On Desktop, #login-header-bar has a shadow if there are 8+ profiles.
if (Oobe.getInstance().displayType == DISPLAY_TYPE.DESKTOP_USER_MANAGER)
$('login-header-bar').classList.toggle('shadow', users.length > 8);
+
+ this.loadPinKeyboardIfNeeded_(users);
+ $('pod-row').loadPods(users);
jdufault 2016/06/23 00:02:31 Why was this moved?
sammiequon 2016/06/23 19:23:21 Done.
},
/**

Powered by Google App Engine
This is Rietveld 408576698