Pin keyboard moved to under the user profile.

chrome/browser/resources/chromeos/login/lock.js

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Login UI based on a stripped down OOBE controller.
  */
 
 <include src="login_shared.js">
 
 // Lazy load polymer.
 (function() {
   'use strict';
 
   // Register loader for custom elements.
   cr.ui.login.ResourceLoader.registerAssets({
     id: 'custom-elements',
     html: [{ url: 'chrome://oobe/custom_elements.html' }]
   });
+// TODO(sammiequon): Remove this method once showPinContainerUser works.

[jdufault, 2016/06/15 22:20:39]

nit: indent
nit: newline before the comment
nit: Please adjust the comment; ie, what is showPinContainerUser?

[sammiequon, 2016/06/17 01:00:43]

Done.

+  var showPinContainer = function(visible) {
+    var authContainer = document.getElementsByClassName('auth-container')[0];
+    var pinContainer = $('pin-container');
+    var signIn = document.getElementsByClassName('signed-in-indicator')[0];
+    var pod = document.getElementsByClassName('pod')[0];
+    var userImage = document.getElementsByClassName('user-image')[0];
+    var elems = [authContainer, pinContainer, signIn, pod, userImage];
+
+    for (var idx = 0; idx < elems.length; idx++) {
+      var currElem = elems[idx];

[jdufault, 2016/06/15 22:20:38]

Typically we don't abbreviate, so either currentElement or just element. Then
elems -> elements

[sammiequon, 2016/06/17 01:00:43]

Done.

+      if (visible) {
+        currElem.classList.add('pin-enabled');
+        currElem.classList.remove('pin-disabled');
+      }
+      else {
+        currElem.classList.add('pin-disabled');

[jdufault, 2016/06/15 22:20:39]

flip-flop the order here so pin-enabled is always the first statement in the two
if bodies.

[sammiequon, 2016/06/17 01:00:43]

Done.

+        currElem.classList.remove('pin-enabled');
+      }
+    }
+  };
+
+  var showPinContainer = function(visible, userPod) {

[jdufault, 2016/06/15 22:20:38]

Only one of these definitions should be committed.

+    var authContainer = userPod.authElement;
+    var pinContainer = userPod.pinKeyboard;
+    var signIn = userPod.signInElement;
+    var pod = userPod;
+    var userImage = userPod.imageElement;

[jdufault, 2016/06/15 22:20:39]

I don't think the local variables give us much in terms of readability; how
about just adding the variable values directly to the array?

[sammiequon, 2016/06/17 01:00:43]

Done.

+    var elems = [authContainer, pinContainer, signIn, pod, userImage];
+
+    for (var idx = 0; idx < elems.length; idx++) {
+      var currElem = elems[idx];
+      if (visible) {
+        currElem.classList.add('pin-enabled');
+        currElem.classList.remove('pin-disabled');
+      }
+      else {
+        currElem.classList.add('pin-disabled');
+        currElem.classList.remove('pin-enabled');
+      }
+    }
+  };
 
   // Called after polymer has been loaded. Fades the pin element in.
   var onPinLoaded = function(pinContainer) {
-    pinContainer.style.opacity = 1;
+    showPinContainer(true);
   };
 
   // We only load the PIN element when it is actually shown so that lock screen
   // load times remain low when the user is not using a PIN.
   //
   // Loading the PIN element blocks the DOM, which will interrupt any running
   // animations. We load the PIN after an idle notification to allow the pod
   // fly-in animation to complete without interruption.
   if (loadTimeData.getBoolean('showPin')) {
     cr.ui.login.ResourceLoader.loadAssetsOnIdle('custom-elements', function() {
@@ skipping 37 matching lines @@
      * Reloads content of the page.
      * @param {!Object} data New dictionary with i18n values.
      */
     reloadContent: function(data) {
       loadTimeData.overrideValues(data);
       i18nTemplate.process(document, loadTimeData);
       Oobe.getInstance().updateLocalizedContent_();
     },
   };
 });