Pin keyboard moved to under the user profile.

ui/login/account_picker/screen_account_picker.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Account picker screen implementation.
  */
-
 login.createScreen('AccountPickerScreen', 'account-picker', function() {

[jdufault, 2016/06/17 18:54:22]

Restore newline

[sammiequon, 2016/06/22 23:26:17]

Done.

   /**
    * Maximum number of offline login failures before online login.
    * @type {number}
    * @const
    */
   var MAX_LOGIN_ATTEMPTS_IN_POD = 3;
 
   return {
     EXTERNAL_API: [
       'loadUsers',
@@ skipping 168 matching lines @@
         var maxHeight =
             cr.ui.LoginUITools.getMaxHeightBeforeShelfOverlapping($('bubble'));
         if (maxHeight < $('bubble').offsetHeight) {
           $('bubble').showContentForElement(activatedPod.mainInput,
                                             cr.ui.Bubble.Attachment.TOP,
                                             error,
                                             BUBBLE_OFFSET, BUBBLE_PADDING);
         }
       }
     },
-
     /**

[jdufault, 2016/06/17 18:54:23]

Restore newline

[sammiequon, 2016/06/22 23:26:17]

Done.

      * Loads the PIN keyboard if any of the users can login with a PIN.
      * @param {array} users Array of user instances.
      */
     loadPinKeyboardIfNeeded_: function(users) {
       for (var i = 0; i < users.length; ++i) {
         var user = users[i];
         if (user.showPin) {
-          showPinKeyboardAsync();
+          var pod = $('pod-row').getPodWithUsername(user.username);
+          if(pod)

[jdufault, 2016/06/17 18:54:23]

nit: if (

[sammiequon, 2016/06/22 23:26:17]

Done.

+            showPinKeyboardAsync(pod, true);

[jdufault, 2016/06/17 18:54:22]

When is there going to be a username with showPin=true but no pod?

[sammiequon, 2016/06/22 23:26:17]

Done.

           return;
         }
       }
     },
 
     /**
      * Loads given users in pod row.
      * @param {array} users Array of user.
      * @param {boolean} showGuest Whether to show guest session button.
      */
     loadUsers: function(users, showGuest) {
+      $('pod-row').loadPods(users);
       this.loadPinKeyboardIfNeeded_(users);
 

[jdufault, 2016/06/17 18:54:23]

I'd put loadPinKeyboardIfNeeded at the end of the function because the other
statements are all directly manipulating DOM.

[sammiequon, 2016/06/22 23:26:17]

Done.

-      $('pod-row').loadPods(users);
       $('login-header-bar').showGuestButton = showGuest;
       // On Desktop, #login-header-bar has a shadow if there are 8+ profiles.
       if (Oobe.getInstance().displayType == DISPLAY_TYPE.DESKTOP_USER_MANAGER)
         $('login-header-bar').classList.toggle('shadow', users.length > 8);
     },
 
     /**
      * Runs app with a given id from the list of loaded apps.
      * @param {!string} app_id of an app to run.
      * @param {boolean=} opt_diagnostic_mode Whether to run the app in
@@ skipping 171 matching lines @@
      * @param {string} userID The user ID of the public session
      * @param {string} locale The locale to which this list of keyboard layouts
      *     applies
      * @param {!Object} list List of available keyboard layouts
      */
     setPublicSessionKeyboardLayouts: function(userID, locale, list) {
       $('pod-row').setPublicSessionKeyboardLayouts(userID, locale, list);
     }
   };
 });