Pin keyboard moved to under the user profile.

chrome/browser/resources/chromeos/login/lock.js

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Login UI based on a stripped down OOBE controller.
  */
 
 <include src="login_shared.js">
 
-// Asynchronously loads the pin keyboard.
-function showPinKeyboardAsync() {
+/**
+ * Asynchronously loads the pin keyboard.
+ * @param {Object) userPod Pod to hide/unhide elements.
+ * @param {boolean} visible Whether to make the pin visible.
+ */
+function showPinKeyboardAsync(userPod, visible) {

[jdufault, 2016/06/17 18:54:22]

Please rename this function now that it can also hide the pin keyboard.

[sammiequon, 2016/06/22 23:26:16]

Done.

   'use strict';
 
+  var setPinVisibility = function(userPod, visible) {

[jdufault, 2016/06/17 18:54:22]

If the |userPod| and |visible| params are removed from this function, then the
|onPinLoaded| function could be removed.

+    var elements = [userPod.authElement, userPod.imageElement,
+                    userPod.signInElement, userPod, userPod.pinContainer];

[jdufault, 2016/06/17 18:54:22]

Make userPod first element in the array?

[sammiequon, 2016/06/22 23:26:16]

Done.

+
+    for (var idx = 0; idx < elements.length; idx++) {
+      var currentElement = elements[idx];
+      if (visible) {
+        currentElement.classList.add('pin-enabled');
+        currentElement.classList.remove('pin-disabled');
+      }
+      else {

[jdufault, 2016/06/17 18:54:22]

nit: } else {

[sammiequon, 2016/06/22 23:26:17]

Done.

+        currentElement.classList.remove('pin-enabled');
+        currentElement.classList.add('pin-disabled');
+      }
+    }
+  };
+
   // This function could get called multiple times. Do nothing if we have
   // already loaded. This check needs to happen before the registerAssets call,
   // because that will clobber the loaded state.
-  if (cr.ui.login.ResourceLoader.alreadyLoadedAssets('custom-elements'))
+  if (cr.ui.login.ResourceLoader.alreadyLoadedAssets('custom-elements')) {
+    setPinVisibility(userPod, visible);
     return;
+  }
 
   // Register loader for custom elements.
   cr.ui.login.ResourceLoader.registerAssets({
     id: 'custom-elements',
     html: [{ url: 'chrome://oobe/custom_elements.html' }]
   });
 
   // Called after polymer has been loaded. Fades the pin element in.
   var onPinLoaded = function(pinContainer) {
-    pinContainer.style.opacity = 1;
+    setPinVisibility(userPod, true);

[jdufault, 2016/06/17 18:54:22]

true should be |visible|, if you call showPinKeyboardAsync for the first time
with |visible|=false then this will fade the keyboard in.

You could also skip loading if |visible|=false. Up to you.

   };
 
   // We only load the PIN element when it is actually shown so that lock screen
   // load times remain low when the user is not using a PIN.
   //
   // Loading the PIN element blocks the DOM, which will interrupt any running
   // animations. We load the PIN after an idle notification to allow the pod
   // fly-in animation to complete without interruption.
   cr.ui.login.ResourceLoader.loadAssetsOnIdle('custom-elements', function() {
     cr.ui.login.ResourceLoader.waitUntilLayoutComplete('pin-container',
@@ skipping 35 matching lines @@
      * Reloads content of the page.
      * @param {!Object} data New dictionary with i18n values.
      */
     reloadContent: function(data) {
       loadTimeData.overrideValues(data);
       i18nTemplate.process(document, loadTimeData);
       Oobe.getInstance().updateLocalizedContent_();
     },
   };
 });