Pin keyboard moved to under the user profile.

ui/login/account_picker/user_pod_row.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview User pod row implementation.
  */
 
 cr.define('login', function() {
   /**
@@ skipping 38 matching lines @@
    * synced with computed CSS sizes of pods.
    */
   var CROS_POD_WIDTH = 180;
   var DESKTOP_POD_WIDTH = 180;
   var MD_DESKTOP_POD_WIDTH = 160;
   var PUBLIC_EXPANDED_BASIC_WIDTH = 500;
   var PUBLIC_EXPANDED_ADVANCED_WIDTH = 610;
   var CROS_POD_HEIGHT = 213;
   var DESKTOP_POD_HEIGHT = 226;
   var MD_DESKTOP_POD_HEIGHT = 200;
-  var POD_ROW_PADDING = 10;
+  var POD_ROW_PADDING = 0;

[jdufault, 2016/05/31 19:24:52]

Have you tested this with multiple pods? We probably want to keep the padding.

   var DESKTOP_ROW_PADDING = 32;
   var CUSTOM_ICON_CONTAINER_SIZE = 40;
 
   /**
    * Minimal padding between user pod and virtual keyboard.
    * @type {number}
    * @const
    */
   var USER_POD_KEYBOARD_MIN_PADDING = 20;
 
@@ skipping 78 matching lines @@
   }
 
   /**
    * Creates a user pod.
    * @constructor
    * @extends {HTMLDivElement}
    */
   var UserPod = cr.ui.define(function() {
     var node = $('user-pod-template').cloneNode(true);
     node.removeAttribute('id');
+

[jdufault, 2016/05/31 19:24:52]

Remove extraneous lines.

[sammiequon, 2016/06/14 22:22:22]

Done.

+
     return node;
   });
 
   /**
    * Stops event propagation from the any user pod child element.
    * @param {Event} e Event to handle.
    */
   function stopEventPropagation(e) {
     // Prevent default so that we don't trigger a 'focus' event.
     e.preventDefault();
@@ skipping 557 matching lines @@
           this.handleRemoveCommandKeyDown_.bind(this));
       this.actionBoxMenuRemoveElement.addEventListener('blur',
           this.handleRemoveCommandBlur_.bind(this));
       this.actionBoxRemoveUserWarningButtonElement.addEventListener(
           'click',
           this.handleRemoveUserConfirmationClick_.bind(this));
         this.actionBoxRemoveUserWarningButtonElement.addEventListener(
             'keydown',
             this.handleRemoveUserConfirmationKeyDown_.bind(this));
 
-      var pinKeyboard = $('pin-keyboard');
-      // The pin keyboard is not present on the md user manager.
-      if (pinKeyboard) {
-        pinKeyboard.addEventListener('submit',
-            this.handlePinSubmitted_.bind(this));
-      }
 
       var customIcon = this.customIconElement;
       customIcon.parentNode.replaceChild(new UserPodCustomIcon(), customIcon);
     },
 
     /**
      * Initializes the pod after its properties set and added to a pod row.
      */
     initialize: function() {
       this.passwordElement.addEventListener('keydown',
@@ skipping 20 matching lines @@
       this.tabIndex = UserPodTabOrder.POD_INPUT;
     },
 
     /**
      * Handles the user hitting 'submit' on the PIN keyboard.
      * @param {Event} e Submit event object.
      * @private
      */
     handlePinSubmitted_: function(e) {
       var pin = e.detail.pin;
-      chrome.send('authenticateUserWithPin', [this.user.username, pin]);
+      chrome.send('authenticateUser', [this.user.username, pin]);

[jdufault, 2016/05/31 19:24:52]

Drop this change, it is handled in a different CL.

     },
 
     /**
      * Handles keypress event (i.e. any textual input) on password input.
      * @param {Event} e Keypress Event object.
      * @private
      */
     handlePasswordKeyPress_: function(e) {
       // When tabbing from the system tray a tab key press is received. Suppress
       // this so as not to type a tab character into the password field.
@@ skipping 1633 matching lines @@
       var userPod;
       if (user.isDesktopUser)
         userPod = new DesktopUserPod({user: user});
       else if (user.publicAccount)
         userPod = new PublicAccountUserPod({user: user});
       else if (user.isApp)
         userPod = new KioskAppPod({user: user});
       else
         userPod = new UserPod({user: user});
 
+      var pinKeyboard = userPod.getElementsByTagName('pin-keyboard');
+
+      var handlePinSubmitted_ = function(e) {
+        var pin = e.detail.pin;
+        // TODO: hardcode this.user.username

[jdufault, 2016/05/31 19:24:52]

Remove TODO?

[sammiequon, 2016/06/14 22:22:22]

Done.

+        chrome.send('authenticateUser', [user.username, pin]);
+      }
+
+      // The pin keyboard is not present on the md user manager.
+      if (pinKeyboard && pinKeyboard.length > 0) {
+       pinKeyboard[0].addEventListener('submit',

[jdufault, 2016/05/31 19:24:52]

Can we add the event listener directly to the |userPod| instance and avoid doing
a DOM query?

[sammiequon, 2016/06/14 22:22:22]

Done.

+           handlePinSubmitted_.bind(this));
+      }
+
+
       userPod.hidden = false;
       return userPod;
     },
 
     /**
      * Add an existing user pod to this pod row.
      * @param {!Object} user User info dictionary.
      */
     addUserPod: function(user) {
       var userPod = this.createUserPod(user);
@@ skipping 915 matching lines @@
        if (pod && pod.multiProfilesPolicyApplied) {
          pod.userTypeBubbleElement.classList.remove('bubble-shown');
        }
      }
   };
 
   return {
     PodRow: PodRow
   };
 });