Issue 202763008: Remove textFieldDidChange(const blink::WebInputElement& element)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 202763008: Remove textFieldDidChange(const blink::WebInputElement& element) (Closed)

Created:
6 years, 9 months ago by ziran.sun

Modified:
6 years, 9 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove textFieldDidChange(const blink::WebInputElement& element) The function argument has been replace by blink::WebFormControlElement&. Since code at both chromium and blink sides are landed. It's safe to remove this redundent function. R=isherman@chromium.org BUG=332557 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259896

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	M	components/autofill/content/renderer/autofill_agent.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	components/autofill/content/renderer/autofill_agent.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

LGTM, thanks. (You will, of course, need to wait for the Blink CL to land ...

6 years, 9 months ago (2014-03-18 19:45:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/202763008/1

6 years, 9 months ago (2014-03-27 10:40:33 UTC) #4

Message was sent while issue was closed.

Change committed as 259896

Expand Messages | Collapse Messages