Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2027623002: Revert of Addendum to OpenType feature detection simplification (Closed)

Created:
4 years, 6 months ago by Guido Urdaneta
Modified:
4 years, 6 months ago
Reviewers:
drott, behdad
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Addendum to OpenType feature detection simplification (patchset #1 id:1 of https://codereview.chromium.org/2026433002/ ) Reason for revert: This CL is suspect of causing fast/text/font-features/caps-native-synthesis.html to fail in the WebKit Win10 bot. See: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/10722 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10?numbuilds=200 I will reland if the revert doesn't fix the bot. Original issue's description: > Addendum to OpenType feature detection simplification > > Addressing Behdad's review comment. > > BUG=603137 > TBR=behdad > > Committed: https://crrev.com/09e8b8a7b8da00f9595df458606c2a133f99a74f > Cr-Commit-Position: refs/heads/master@{#396714} TBR=behdad@chromium.org,drott@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603137 Committed: https://crrev.com/3d9eeeefe535a25f319998c3d2cd848452bf5a03 Cr-Commit-Position: refs/heads/master@{#396835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Guido Urdaneta
Created Revert of Addendum to OpenType feature detection simplification
4 years, 6 months ago (2016-05-31 13:50:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027623002/1
4 years, 6 months ago (2016-05-31 13:50:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 15:52:56 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 15:55:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d9eeeefe535a25f319998c3d2cd848452bf5a03
Cr-Commit-Position: refs/heads/master@{#396835}

Powered by Google App Engine
This is Rietveld 408576698