Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2027603002: [crankshaft] Properly optimize strict equality with constants. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Properly optimize strict equality with constants. For values with canonical representation (i.e. not Number, Simd128Value or Number) we can turn a strict equality comparison to a direct pointer comparison. This removes the weird performance cliff when using a null or undefined constant instead of the literals. R=jarin@chromium.org BUG=v8:5042 Committed: https://crrev.com/1f51868401a61b2fa19798e866a5a184e0226948 Cr-Commit-Position: refs/heads/master@{#36612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M src/crankshaft/hydrogen.cc View 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-05-31 11:29:09 UTC) #1
Benedikt Meurer
Hey Jaro, Quick fix for the strict equality with know compile time constant issue. Please ...
4 years, 6 months ago (2016-05-31 11:30:27 UTC) #2
Jarin
lgtm
4 years, 6 months ago (2016-05-31 11:35:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027603002/1
4 years, 6 months ago (2016-05-31 11:35:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 11:58:53 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 11:59:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f51868401a61b2fa19798e866a5a184e0226948
Cr-Commit-Position: refs/heads/master@{#36612}

Powered by Google App Engine
This is Rietveld 408576698