Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 2027593003: Resolve target specification relative to script. (Closed)

Created:
4 years, 6 months ago by ahe
Modified:
4 years, 6 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Sort show clause. #

Patch Set 3 : Fix automated tests. #

Patch Set 4 : Use Isolate.resolvePackageUri. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M lib/src/rastak.dart View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
ahe
4 years, 6 months ago (2016-05-31 14:49:07 UTC) #2
kasperl
LGTM. https://codereview.chromium.org/2027593003/diff/1/lib/src/rastak.dart File lib/src/rastak.dart (right): https://codereview.chromium.org/2027593003/diff/1/lib/src/rastak.dart#newcode11 lib/src/rastak.dart:11: Platform, Sort alphabetically?
4 years, 6 months ago (2016-05-31 17:47:04 UTC) #3
ahe
Thank you, Kasper! https://codereview.chromium.org/2027593003/diff/1/lib/src/rastak.dart File lib/src/rastak.dart (right): https://codereview.chromium.org/2027593003/diff/1/lib/src/rastak.dart#newcode11 lib/src/rastak.dart:11: Platform, On 2016/05/31 17:47:04, kasperl wrote: ...
4 years, 6 months ago (2016-05-31 22:28:22 UTC) #4
ahe
PTAL, I had to make additional changes to get automated tests working.
4 years, 6 months ago (2016-06-01 06:34:36 UTC) #5
kasperl
It's a little bit nasty to have to update the global state like that, but ...
4 years, 6 months ago (2016-06-01 06:36:42 UTC) #6
ahe
On 2016/06/01 06:36:42, kasperl wrote: > It's a little bit nasty to have to update ...
4 years, 6 months ago (2016-06-01 06:50:12 UTC) #7
kasperl
STV!
4 years, 6 months ago (2016-06-01 08:47:25 UTC) #8
ahe
4 years, 6 months ago (2016-06-01 09:05:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
9bc4b6fa7d9849f103b13b2e987a48dfde55a438 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698