Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2027593002: [turbofan] Distinguish between change- and truncate-tagged-to-float64. (Closed)

Created:
4 years, 6 months ago by Jarin
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Distinguish between change- and truncate-tagged-to-float64. This prevents the compiler from optimizing f64-to-tagged(tagged-to-f64(x)) ==> x for non-number x (such as undefined). Committed: https://crrev.com/5e96f47bc895f3cba7179d6e4a6ab27488c5a576 Cr-Commit-Position: refs/heads/master@{#36613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -8 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 chunk +4 lines, -1 line 0 comments Download
A + test/mjsunit/compiler/regress-truncate-number-or-undefined-to-float64.js View 1 chunk +12 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 6 months ago (2016-05-31 11:14:21 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-05-31 11:27:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027593002/1
4 years, 6 months ago (2016-05-31 11:28:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 12:00:04 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 12:01:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e96f47bc895f3cba7179d6e4a6ab27488c5a576
Cr-Commit-Position: refs/heads/master@{#36613}

Powered by Google App Engine
This is Rietveld 408576698