service worker: Avoid starting up for activation during shutdown

base/compiler_specific.h

Index: base/compiler_specific.h
diff --git a/base/compiler_specific.h b/base/compiler_specific.h
index 17e1f688419a8b1b8c1d104c1f3fcd5b8ddf7566..b182b030d4ab5f493068b05899bd99f7894dc6a5 100644
--- a/base/compiler_specific.h
+++ b/base/compiler_specific.h
@@ -55,8 +55,9 @@
 // Note that this is intended to be used only when no access to the base class'
 // static data is done through derived classes or inline methods. For more info,
 // see http://msdn.microsoft.com/en-us/library/3tdb471s(VS.80).aspx
-#define NON_EXPORTED_BASE(code) MSVC_SUPPRESS_WARNING(4275) \
-                                code
+#define NON_EXPORTED_BASE(...) \

[nhiroki, 2016/06/01 05:51:47]

Why do we need this change?

[falken, 2016/06/01 09:20:05]

For some reason ServiceWorkerRegistration had to become RefCountedThreadSafe
after it started using the timer. It must use DeleteOnIOThread or some crashes
happen. That means it went from inheriting:
base::RefCounted<ServiceWorkerRegistration>
to:
base::RefCountedThreadSafe<ServiceWorkerRegistration,
BrowserThread::DeleteOnIOThread> 

That comma destroys the NON_EXPORTED_BASE macro since it thinks it's two
arguments.

+  MSVC_SUPPRESS_WARNING(4275)  \
+  __VA_ARGS__
 
 #else  // Not MSVC
 
@@ -67,7 +68,7 @@
 #define MSVC_POP_WARNING()
 #define MSVC_DISABLE_OPTIMIZE()
 #define MSVC_ENABLE_OPTIMIZE()
-#define NON_EXPORTED_BASE(code) code
+#define NON_EXPORTED_BASE(...) __VA_ARGS__
 
 #endif  // COMPILER_MSVC