Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2027583002: service worker: Avoid starting up for activation during shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add unittest Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_registration.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index bd3a4d4e80d88edb9966d31df8938d62f3b49821..3d69c15ad7d6e55b77b357c3337b4f9f7f463ed8 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -49403,7 +49403,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="ServiceWorker.ActivateEventStatus"
enum="ServiceWorkerStatusCode">
<owner>falken@chromium.org</owner>
- <summary>The result of dispatching the activate event to the worker.</summary>
+ <summary>
+ The result of dispatching the activate event to the worker. This is recorded
+ to both ServiceWorker.ActivateEventStatus and whichever of
+ ServiceWorker.ActivateEventStatus_InShutdown
+ ServiceWorker.ActivateEventStatus_NotInShutdown is appropriate. (InShutdown
+ means the context was null or ServiceWorkerProcessManger::Shutdown was
+ called.)
+ </summary>
</histogram>
<histogram name="ServiceWorker.BackgroundSyncEvent.Time" units="ms">
@@ -96796,6 +96803,12 @@ To add a new entry, add it with any value and run test to compute valid value.
<suffix name="3" label="Failed three times."/>
</histogram_suffixes>
+<histogram_suffixes name="ServiceWorker.ShutdownStatus">
+ <affected-histogram name="ServiceWorker.ActivateEventStatus"/>
+ <suffix name="InShutdown" label="Browser shutdown started."/>
+ <suffix name="NotInShutdown" label="Browser shutdown has not started."/>
+</histogram_suffixes>
+
<histogram_suffixes name="ServiceWorker.StartSituation">
<affected-histogram name="EmbeddedWorkerInstance.Start.TimeToEvaluateScript"/>
<affected-histogram name="EmbeddedWorkerInstance.Start.TimeToLoad.HttpCache"/>
« no previous file with comments | « content/browser/service_worker/service_worker_registration.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698