tools/metrics/histograms/histograms.xml - Issue 2027583002: service worker: Avoid starting up for activation during shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2027583002: service worker: Avoid starting up for activation during shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add unittest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index bd3a4d4e80d88edb9966d31df8938d62f3b49821..3d69c15ad7d6e55b77b357c3337b4f9f7f463ed8 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -49403,7 +49403,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram name="ServiceWorker.ActivateEventStatus"

enum="ServiceWorkerStatusCode">

<owner>falken@chromium.org</owner>

- <summary>The result of dispatching the activate event to the worker.</summary>

+ <summary>

+ The result of dispatching the activate event to the worker. This is recorded

+ to both ServiceWorker.ActivateEventStatus and whichever of

+ ServiceWorker.ActivateEventStatus_InShutdown

+ ServiceWorker.ActivateEventStatus_NotInShutdown is appropriate. (InShutdown

+ means the context was null or ServiceWorkerProcessManger::Shutdown was

+ called.)

+ </summary>

</histogram>

@@ -96796,6 +96803,12 @@ To add a new entry, add it with any value and run test to compute valid value.

</histogram_suffixes>

+<histogram_suffixes name="ServiceWorker.ShutdownStatus">

+ <affected-histogram name="ServiceWorker.ActivateEventStatus"/>

+ <suffix name="InShutdown" label="Browser shutdown started."/>

+ <suffix name="NotInShutdown" label="Browser shutdown has not started."/>

+</histogram_suffixes>

<histogram_suffixes name="ServiceWorker.StartSituation">

<affected-histogram name="EmbeddedWorkerInstance.Start.TimeToEvaluateScript"/>

<affected-histogram name="EmbeddedWorkerInstance.Start.TimeToLoad.HttpCache"/>

« no previous file with comments | « content/browser/service_worker/service_worker_registration.cc ('k') | no next file » | no next file with comments »