Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2027553006: Truncate long file name with ellipsis. (Closed)

Created:
4 years, 6 months ago by oka
Modified:
4 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Truncate long file name with ellipsis. BUG=524114 TEST=manually Committed: https://crrev.com/f6947ca76f4d22620f755487f957bb24f4038960 Cr-Commit-Position: refs/heads/master@{#398263}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix #

Total comments: 2

Patch Set 3 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/file_manager/gallery/css/gallery.css View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
oka
PTAL
4 years, 6 months ago (2016-06-01 12:23:30 UTC) #2
fukino
https://codereview.chromium.org/2027553006/diff/1/ui/file_manager/gallery/gallery.html File ui/file_manager/gallery/gallery.html (right): https://codereview.chromium.org/2027553006/diff/1/ui/file_manager/gallery/gallery.html#newcode57 ui/file_manager/gallery/gallery.html:57: input { * You should write styles in css ...
4 years, 6 months ago (2016-06-02 07:21:05 UTC) #3
oka
On 2016/06/02 07:21:05, fukino wrote: > https://codereview.chromium.org/2027553006/diff/1/ui/file_manager/gallery/gallery.html > File ui/file_manager/gallery/gallery.html (right): > > https://codereview.chromium.org/2027553006/diff/1/ui/file_manager/gallery/gallery.html#newcode57 > ...
4 years, 6 months ago (2016-06-06 09:37:25 UTC) #4
oka
PTAL
4 years, 6 months ago (2016-06-06 09:37:33 UTC) #5
fukino
lgtm with a nit. https://codereview.chromium.org/2027553006/diff/20001/ui/file_manager/gallery/css/gallery.css File ui/file_manager/gallery/css/gallery.css (right): https://codereview.chromium.org/2027553006/diff/20001/ui/file_manager/gallery/css/gallery.css#newcode345 ui/file_manager/gallery/css/gallery.css:345: text-overflow: ellipsis; nit: Sort the ...
4 years, 6 months ago (2016-06-06 09:56:05 UTC) #6
oka
https://codereview.chromium.org/2027553006/diff/20001/ui/file_manager/gallery/css/gallery.css File ui/file_manager/gallery/css/gallery.css (right): https://codereview.chromium.org/2027553006/diff/20001/ui/file_manager/gallery/css/gallery.css#newcode345 ui/file_manager/gallery/css/gallery.css:345: text-overflow: ellipsis; On 2016/06/06 09:56:05, fukino wrote: > nit: ...
4 years, 6 months ago (2016-06-07 09:17:13 UTC) #7
oka
4 years, 6 months ago (2016-06-07 09:17:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027553006/40001
4 years, 6 months ago (2016-06-07 09:18:00 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-07 10:02:09 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 10:03:16 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f6947ca76f4d22620f755487f957bb24f4038960
Cr-Commit-Position: refs/heads/master@{#398263}

Powered by Google App Engine
This is Rietveld 408576698