Issue 202753003: Rationalize the git config settings for index-pack performance.

Issue 202753003: Rationalize the git config settings for index-pack performance. (Closed)

Created:
6 years, 9 months ago by szager1

Modified:
6 years, 9 months ago

Reviewers:
Dirk Pranke, Michael Moss, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Rationalize the git config settings for index-pack performance. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=257728

Patch Set 2 : comment #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -10 lines)			Patch
M	fetch.py	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	gclient_scm.py	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	gclient_utils.py	View	1	2 chunks	+21 lines, -0 lines	1 comment	Download
M	git_cache.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

seems plausible. someone else closer to the git-cache code should also review.

6 years, 9 months ago (2014-03-17 23:46:14 UTC) #2

iannucci

lgtm https://codereview.chromium.org/202753003/diff/20001/gclient_utils.py File gclient_utils.py (right): https://codereview.chromium.org/202753003/diff/20001/gclient_utils.py#newcode975 gclient_utils.py:975: return '512m' for future: I'd really like if ...

6 years, 9 months ago (2014-03-18 20:24:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/202753003/20001

6 years, 9 months ago (2014-03-18 20:29:32 UTC) #6

Message was sent while issue was closed.

Change committed as 257728

Expand Messages | Collapse Messages