Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2027523002: Remove an out-dated TODO in MainThreadDebugger (Closed)

Created:
4 years, 6 months ago by haraken
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, keishi
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an out-dated TODO in MainThreadDebugger MainThreadDebugger is no longer on Oilpan's heap. BUG= Committed: https://crrev.com/60cdc44ff381ec9e2c6aeaaf2ecdc3fdc74bf5ce Cr-Commit-Position: refs/heads/master@{#396793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
haraken
PTAL
4 years, 6 months ago (2016-05-31 05:14:18 UTC) #2
keishi
LGTM
4 years, 6 months ago (2016-05-31 05:17:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027523002/1
4 years, 6 months ago (2016-05-31 05:19:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 06:42:31 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 06:43:41 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/60cdc44ff381ec9e2c6aeaaf2ecdc3fdc74bf5ce
Cr-Commit-Position: refs/heads/master@{#396793}

Powered by Google App Engine
This is Rietveld 408576698