Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2027473002: Deprecate use of user gestures during scroll-related touch events (Closed)

Created:
4 years, 6 months ago by Rick Byers
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Deprecate use of user gestures during scroll-related touch events See https://docs.google.com/document/d/1oF1T3O7_E4t1PYHV6gyCwHxOi3ystm0eSL5xZu7nvOg/edit#heading=h.qq59ev3u8fba Intent to deprecate: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/2cvwbgZOZZs This also contains a small tweak to the semantics of the TouchScrollStarted event to trigger it only on the first GestureScrollUpdate (so that it's not triggered when the page consumes all touchmove events). BUG=611981 Review-Url: https://codereview.chromium.org/1996143002 Cr-Commit-Position: refs/heads/master@{#396215} (cherry picked from commit adbb8a0133bf42306ac4a533a5478529e5d87895) Committed: https://chromium.googlesource.com/chromium/src/+/34f0006c461c94b01317c5521140f995cec1badc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -21 lines) Patch
M content/browser/renderer_host/input/input_router_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 2 chunks +12 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/resources/touch-stale-node-crash.js View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.h View 3 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.cpp View 6 chunks +58 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Rick Byers
4 years, 6 months ago (2016-05-30 16:06:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
34f0006c461c94b01317c5521140f995cec1badc.

Powered by Google App Engine
This is Rietveld 408576698