Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2027453002: Dispatch middle click manually by tracking mouse (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Dispatch middle click manually by tracking mouse Tracking targets for middle button mousedown event and fire click event for it on mouse up if necessary. Note: The click is not finding the common parent of mousedown and up targets for simplicty and only sends the click to the target if both down and up happened on the same node. BUG=608697 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1963823002 Cr-Commit-Position: refs/heads/master@{#395707} (cherry picked from commit 88eb1110baafcba070e750866a343e81b6bcc524) Committed: https://chromium.googlesource.com/chromium/src/+/4d43781be25ba16cb8a8be67a64a32d6991bb53d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/browser/resources/ntp4/new_tab.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/ntp4/synthetic_middleclick.js View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 6 months ago (2016-05-30 15:58:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d43781be25ba16cb8a8be67a64a32d6991bb53d.

Powered by Google App Engine
This is Rietveld 408576698