Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2027433002: MIPS: Fix _rebased_android_toolchain_root name spelling error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 # ] 339 # ]
340 #} 340 #}
341 } else if (linux_use_bundled_binutils) { 341 } else if (linux_use_bundled_binutils) {
342 # Gold is the default linker for the bundled binutils so we explicitly 342 # Gold is the default linker for the bundled binutils so we explicitly
343 # enable the bfd linker when use_gold is not set. 343 # enable the bfd linker when use_gold is not set.
344 ldflags += [ "-fuse-ld=bfd" ] 344 ldflags += [ "-fuse-ld=bfd" ]
345 } else if (is_android && current_cpu == "mipsel" && is_clang) { 345 } else if (is_android && current_cpu == "mipsel" && is_clang) {
346 # Let clang find the ld.bfd in the NDK. 346 # Let clang find the ld.bfd in the NDK.
347 _rebased_android_toolchain_root = 347 _rebased_android_toolchain_root =
348 rebase_path(android_toolchain_root, root_build_dir) 348 rebase_path(android_toolchain_root, root_build_dir)
349 ldflags += [ "--gcc-toolchain=$rebased_android_toolchain_root" ] 349 ldflags += [ "--gcc-toolchain=$_rebased_android_toolchain_root" ]
350 } 350 }
351 351
352 if (is_posix && (use_gold || (use_lld && !is_nacl)) && !using_sanitizer && 352 if (is_posix && (use_gold || (use_lld && !is_nacl)) && !using_sanitizer &&
353 !(is_android && use_order_profiling)) { 353 !(is_android && use_order_profiling)) {
354 # TODO(crbug.com/576197) - gcc on x86 platforms + gold + icf=all 354 # TODO(crbug.com/576197) - gcc on x86 platforms + gold + icf=all
355 # doesn't currently work. Once it does, use icf=all everywhere. 355 # doesn't currently work. Once it does, use icf=all everywhere.
356 # Additionally, on Android x86 --icf=safe seems to cause issues as well. 356 # Additionally, on Android x86 --icf=safe seems to cause issues as well.
357 if (is_clang || (target_cpu != "x86" && target_cpu != "x64")) { 357 if (is_clang || (target_cpu != "x86" && target_cpu != "x64")) {
358 ldflags += [ "-Wl,--icf=all" ] 358 ldflags += [ "-Wl,--icf=all" ]
359 } else if (!is_android) { 359 } else if (!is_android) {
(...skipping 1097 matching lines...) Expand 10 before | Expand all | Expand 10 after
1457 1457
1458 if (is_ios || is_mac) { 1458 if (is_ios || is_mac) {
1459 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1459 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1460 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1460 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1461 config("enable_arc") { 1461 config("enable_arc") {
1462 common_flags = [ "-fobjc-arc" ] 1462 common_flags = [ "-fobjc-arc" ]
1463 cflags_objc = common_flags 1463 cflags_objc = common_flags
1464 cflags_objcc = common_flags 1464 cflags_objcc = common_flags
1465 } 1465 }
1466 } 1466 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698