Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2027413002: Recognize common parametric gamma (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Recognize common parametric gamma 5% of images with ICC profiles (in my test set of 10k) have this exact gamma representation, which is very close to 2.2f. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2027413002 Committed: https://skia.googlesource.com/skia/+/81e4cc7723ea87de8b8917e52cc25f524225fa43

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -79 lines) Patch
M src/core/SkColorSpace.cpp View 2 chunks +100 lines, -79 lines 3 comments Download

Messages

Total messages: 14 (7 generated)
msarett
https://codereview.chromium.org/2027413002/diff/1/src/core/SkColorSpace.cpp File src/core/SkColorSpace.cpp (right): https://codereview.chromium.org/2027413002/diff/1/src/core/SkColorSpace.cpp#newcode580 src/core/SkColorSpace.cpp:580: if (color_space_almost_equal(0.9479f, a) && Of my set of 10k ...
4 years, 6 months ago (2016-06-01 21:01:20 UTC) #4
scroggo
lgtm https://codereview.chromium.org/2027413002/diff/1/src/core/SkColorSpace.cpp File src/core/SkColorSpace.cpp (right): https://codereview.chromium.org/2027413002/diff/1/src/core/SkColorSpace.cpp#newcode488 src/core/SkColorSpace.cpp:488: uint16_t format = read_big_endian_short(src + 8); Do these ...
4 years, 6 months ago (2016-06-01 21:23:12 UTC) #5
msarett
https://codereview.chromium.org/2027413002/diff/1/src/core/SkColorSpace.cpp File src/core/SkColorSpace.cpp (right): https://codereview.chromium.org/2027413002/diff/1/src/core/SkColorSpace.cpp#newcode488 src/core/SkColorSpace.cpp:488: uint16_t format = read_big_endian_short(src + 8); On 2016/06/01 21:23:12, ...
4 years, 6 months ago (2016-06-01 21:26:13 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027413002/1
4 years, 6 months ago (2016-06-01 21:26:38 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 21:41:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027413002/1
4 years, 6 months ago (2016-06-01 21:42:43 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 21:43:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/81e4cc7723ea87de8b8917e52cc25f524225fa43

Powered by Google App Engine
This is Rietveld 408576698