Issue 20274002: Don't duplicate ceiling() for every POSIX platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20274002: Don't duplicate ceiling() for every POSIX platform. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer

Modified:
7 years, 5 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't duplicate ceiling() for every POSIX platform. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15872

Patch Set 3 : Fix typo #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -40 lines)			Patch
M	src/platform-cygwin.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/platform-freebsd.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/platform-linux.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/platform-macos.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/platform-openbsd.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/platform-posix.cc	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/platform-solaris.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit https://codereview.chromium.org/20274002/diff/1/src/platform-posix.cc File src/platform-posix.cc (right): https://codereview.chromium.org/20274002/diff/1/src/platform-posix.cc#newcode215 src/platform-posix.cc:215: if (-1.0 < x && ...

7 years, 5 months ago (2013-07-25 08:32:46 UTC) #2

Benedikt Meurer

7 years, 5 months ago (2013-07-25 08:49:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r15872 (presubmit successful).

Expand Messages | Collapse Messages

Issue 20274002: Don't duplicate ceiling() for every POSIX platform. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address nit #

Patch Set 3 : Fix typo #

Messages