appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py - Issue 2027333002: [Findit] don't included skipped or unknown tests in swarming tasks into failed tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py

Issue 2027333002: [Findit] don't included skipped or unknown tests in swarming tasks into failed tests. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Make sure only collect swarming result for targeted tests. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/waterfall/process_swarming_task_result_pipeline.py ('K') | « appengine/findit/waterfall/process_swarming_task_result_pipeline.py ('k') | appengine/findit/waterfall/test/data/m_b_223_abc_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py

diff --git a/appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py b/appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py

index 912dd2f9df6762bd27efaabdfef46cbafdee0b65..372f0447fd624acf2ede98843f22ab1ebac69ef9 100644

--- a/appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py

+++ b/appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py

@@ -34,7 +34,7 @@ class SwarmingTasksToTryJobPipeline(BasePipeline):

task_id = yield TriggerSwarmingTaskPipeline(

master_name, builder_name, build_number, step_name, tests)

step_future = yield ProcessSwarmingTaskResultPipeline(

- master_name, builder_name, build_number, step_name, task_id)

+ master_name, builder_name, build_number, step_name, task_id, tests)

logging_str = (

'Swarming task was scheduled for build %s/%s/%s step %s') % (

master_name, builder_name, build_number, step_name)