appengine/findit/model/wf_swarming_task.py - Issue 2027333002: [Findit] don't included skipped or unknown tests in swarming tasks into failed tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/model/wf_swarming_task.py

Issue 2027333002: [Findit] don't included skipped or unknown tests in swarming tasks into failed tests. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/model/test/wf_swarming_task_test.py ('k') | appengine/findit/waterfall/detect_first_failure_pipeline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/model/wf_swarming_task.py

diff --git a/appengine/findit/model/wf_swarming_task.py b/appengine/findit/model/wf_swarming_task.py

index 14dc1596f07d9ea4c117165e2589fa9dad790bfd..88107889460b5b82b97867e4002c7325758c10d8 100644

--- a/appengine/findit/model/wf_swarming_task.py

+++ b/appengine/findit/model/wf_swarming_task.py

@@ -46,15 +46,20 @@ class WfSwarmingTask(BaseBuildModel):

example format would be:

{

'flaky_tests': ['test1', 'test2', ...],

- 'reliable_tests': ['test3', ...]

+ 'reliable_tests': ['test3', ...],

+ 'unknown_tests': ['test4', ...]

}

"""

classified_tests = defaultdict(list)

for test_name, test_statuses in self.tests_statuses.iteritems():

if test_statuses.get('SUCCESS'): # Test passed for some runs, flaky.

classified_tests['flaky_tests'].append(test_name)

+ elif test_statuses.get('UNKNOWN'):

+ classified_tests['unknown_tests'].append(test_name)

else:

# Here we consider a 'non-flaky' test to be 'reliable'.

+ # If the test is 'SKIPPED', there should be failure in its dependency,

+ # consider it to be failed as well.

# TODO(chanli): Check more test statuses.

classified_tests['reliable_tests'].append(test_name)

return classified_tests