[Findit] don't included skipped or unknown tests in swarming tasks into failed tests.

appengine/findit/waterfall/detect_first_failure_pipeline.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import json
 
 from common import constants
 from common.http_client_appengine import HttpClientAppengine as HttpClient
 from common.pipeline_wrapper import BasePipeline
 from common.pipeline_wrapper import pipeline
 from common.waterfall import failure_type
 from model.wf_analysis import WfAnalysis
 from model.wf_step import WfStep
 from waterfall import build_util
 from waterfall import buildbot
 from waterfall import swarming_util
 
 
 _MAX_BUILDS_TO_CHECK = 20
+_NON_FAILURE_STATUS = ['SUCCESS', 'SKIPPED', 'UNKNOWN']
 
 
 class DetectFirstFailurePipeline(BasePipeline):
   """A pipeline to detect first failure of each step.
 
   TODO(stgao): do test-level detection for gtest.
   """
 
   def _ExtractBuildInfo(self, master_name, builder_name, build_number):
     """Returns a BuildInfo instance for the specified build."""
@@ skipping 143 matching lines @@
       self, json_data, step, failed_step=None):
     """Parses the json data and saves all the reliable failures to the step."""
     failed_test_log = {}
     if failed_step:
       failed_step['tests'] = {}
 
     for iteration in json_data.get('per_iteration_data'):
       for test_name in iteration.keys():
         is_reliable_failure = True
 
-        if any(test['status'] == 'SUCCESS' for test in iteration[test_name]):
-          # Ignore the test if any of the attempts were 'SUCCESS'.
+        if (any(test['status'] in _NON_FAILURE_STATUS
+            for test in iteration[test_name])):
+          # Ignore the test if any of the attempts didn't fail.

[stgao, 2016/06/03 06:59:40]

Please add explanation why skipped test should be treated as not failed.

[chanli, 2016/06/06 22:41:29]

Done.

           is_reliable_failure = False
 
         if is_reliable_failure:
           if failed_step:
             # Adds the test to failed_step.
             failed_step['tests'][test_name] = {
                 'current_failure': failed_step['current_failure'],
                 'first_failure': failed_step['current_failure'],
             }
             if failed_step.get('last_pass'):
@@ skipping 266 matching lines @@
 
     failure_info['builds'] = builds
     failure_info['failed_steps'] = failed_steps
 
     analysis = WfAnalysis.Get(master_name, builder_name, build_number)
     analysis.not_passed_steps = build_info.not_passed_steps
     analysis.build_failure_type = build_failure_type
     analysis.put()
 
     return failure_info