Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: appengine/findit/waterfall/test/swarming_tasks_to_try_job_pipeline_test.py

Issue 2027333002: [Findit] don't included skipped or unknown tests in swarming tasks into failed tests. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import json 5 import json
6 6
7 from common.git_repository import GitRepository 7 from common.git_repository import GitRepository
8 from common.pipeline_wrapper import pipeline_handlers 8 from common.pipeline_wrapper import pipeline_handlers
9 from common.waterfall import buildbucket_client 9 from common.waterfall import buildbucket_client
10 from model import result_status 10 from model import result_status
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 self.assertEqual(analysis.result_status, 245 self.assertEqual(analysis.result_status,
246 result_status.FOUND_UNTRIAGED) 246 result_status.FOUND_UNTRIAGED)
247 self.assertEqual(analysis.suspected_cls, 247 self.assertEqual(analysis.suspected_cls,
248 [expected_suspected_cl]) 248 [expected_suspected_cl])
249 249
250 def testSuccessfullyScheduleNewTryJobForTest(self): 250 def testSuccessfullyScheduleNewTryJobForTest(self):
251 master_name = 'm' 251 master_name = 'm'
252 builder_name = 'b' 252 builder_name = 'b'
253 build_number = 1 253 build_number = 1
254 targeted_tests = { 254 targeted_tests = {
255 'a_test': ['TestSuite1.test1', 'TestSuite1.test3'], 255 'a_test': ['TestSuite1.PRE_test1', 'TestSuite1.test3'],
256 'b_test': [], # Non-swarming test. 256 'b_test': [], # Non-swarming test.
257 } 257 }
258 258
259 # Mocks for TriggerSwarmingTaskPipeline. 259 # Mocks for TriggerSwarmingTaskPipeline.
260 def MockedDownloadSwarmingTaskData(*_): 260 def MockedDownloadSwarmingTaskData(*_):
261 return [{'task_id': '1'}, {'task_id': '2'}] 261 return [{'task_id': '1'}, {'task_id': '2'}]
262 self.mock(swarming_util, 'ListSwarmingTasksDataByTags', 262 self.mock(swarming_util, 'ListSwarmingTasksDataByTags',
263 MockedDownloadSwarmingTaskData) 263 MockedDownloadSwarmingTaskData)
264 264
265 def MockedGetSwarmingTaskRequest(ref_task_id, *_): 265 def MockedGetSwarmingTaskRequest(ref_task_id, *_):
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 } 388 }
389 } 389 }
390 } 390 }
391 } 391 }
392 ] 392 ]
393 393
394 self.assertEqual(expected_try_job_results, try_job.test_results) 394 self.assertEqual(expected_try_job_results, try_job.test_results)
395 self.assertEqual(analysis.result_status, 395 self.assertEqual(analysis.result_status,
396 result_status.FOUND_UNTRIAGED) 396 result_status.FOUND_UNTRIAGED)
397 self.assertEqual(analysis.suspected_cls, [expected_suspected_cl]) 397 self.assertEqual(analysis.suspected_cls, [expected_suspected_cl])
OLDNEW
« no previous file with comments | « appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698