Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: content/test/data/media/mediarecorder_test.html

Issue 2027323003: MediaRecorder: parameterise certain browsertests by video codec and/or encode accelerator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adding parameterisation support for enable/disable encode accelerator Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/data/media/mediarecorder_test.html
diff --git a/content/test/data/media/mediarecorder_test.html b/content/test/data/media/mediarecorder_test.html
index c5b078aa1b5d0891985bca7721957fd065520ff7..72a707f5f6738f5cefc51d4dd2ee2f5d56253069 100644
--- a/content/test/data/media/mediarecorder_test.html
+++ b/content/test/data/media/mediarecorder_test.html
@@ -87,7 +87,7 @@ function createAndStartMediaRecorder(stream, mimeType, slice) {
return new Promise(function(resolve, reject) {
document.getElementById('video').src = URL.createObjectURL(stream);
var recorder = new MediaRecorder(stream, {'mimeType' : mimeType});
- console.log('Recorder object created.');
+ console.log('Recorder object created, mimeType = ' + mimeType);
if (slice != undefined) {
recorder.start(slice);
console.log('Recorder started with time slice', slice);
@@ -168,13 +168,14 @@ function testStartStopAndRecorderState() {
// Tests that when MediaRecorder's start() function is called, some data is
// made available by media recorder via dataavailable events, containing non
// empty blob data.
-function testStartAndDataAvailable() {
+function testStartAndDataAvailable(codec) {
var videoSize = 0;
var emptyBlobs = 0;
var timeStamps = [];
+ const mimeType = codec ? "video/webm;codecs=" + String(codec) : "";
navigator.mediaDevices.getUserMedia(DEFAULT_CONSTRAINTS)
.then(function(stream) {
- return createAndStartMediaRecorder(stream, DEFAULT_RECORDER_MIME_TYPE);
+ return createAndStartMediaRecorder(stream, mimeType);
})
.then(function(recorder) {
// Save history of Blobs received via dataavailable.
@@ -206,14 +207,14 @@ function testStartAndDataAvailable() {
// Tests that when MediaRecorder's start(timeSlice) is called, some data
// available events are fired containing non empty blob data.
-function testStartWithTimeSlice() {
+function testStartWithTimeSlice(codec) {
var videoSize = 0;
var emptyBlobs = 0;
var timeStamps = [];
+ const mimeType = codec ? "video/webm;codecs=" + String(codec) : "";
navigator.mediaDevices.getUserMedia(DEFAULT_CONSTRAINTS)
.then(function(stream) {
- return createAndStartMediaRecorder(stream, DEFAULT_RECORDER_MIME_TYPE,
- DEFAULT_TIME_SLICE);
+ return createAndStartMediaRecorder(stream, mimeType, DEFAULT_TIME_SLICE);
})
.then(function(recorder) {
recorder.ondataavailable = function(event) {
@@ -234,12 +235,8 @@ function testStartWithTimeSlice() {
assertTrue(emptyBlobs == 0, 'Recording has ' + emptyBlobs +
' empty blobs, there should be no such empty blobs.');
})
- .catch(function(err) {
- return failTest(err.toString());
- })
- .then(function() {
- reportTestSuccess();
- });
+ .catch(function(err) { return failTest(err.toString()); })
+ .then(function() { reportTestSuccess(); });
}
@@ -290,12 +287,13 @@ function testIllegalResumeThrowsDOMError() {
}
// Tests that MediaRecorder sends data blobs when resume() is called.
-function testResumeAndDataAvailable() {
+function testResumeAndDataAvailable(codec) {
var videoSize = 0;
var emptyBlobs = 0;
+ const mimeType = codec ? "video/webm;codecs=" + String(codec) : "";
navigator.mediaDevices.getUserMedia(DEFAULT_CONSTRAINTS)
.then(function(stream) {
- return createAndStartMediaRecorder(stream, DEFAULT_RECORDER_MIME_TYPE);
+ return createAndStartMediaRecorder(stream, mimeType);
})
.then(function(recorder) {
recorder.pause();

Powered by Google App Engine
This is Rietveld 408576698