Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2027173002: [MIPS] Use gold as default linker for Linux (Closed)

Created:
4 years, 6 months ago by lmilko
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, petar.jovanovic, gordana.cmiljanovic_imgtec.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MIPS] Use gold as default linker for Linux Start using bundled gold as default linker for Linux MIPS, since gold in current bundled binutils (2.26) supports mips32. BUG=none TEST=Build Chromium for Linux MIPS Committed: https://crrev.com/867134974146cb103320e398e7544b717bbbc0fe Cr-Commit-Position: refs/heads/master@{#397246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/compiler.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
lmilko
Please take a look.
4 years, 6 months ago (2016-06-01 12:54:54 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-01 17:03:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027173002/1
4 years, 6 months ago (2016-06-01 19:15:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 21:17:23 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/867134974146cb103320e398e7544b717bbbc0fe Cr-Commit-Position: refs/heads/master@{#397246}
4 years, 6 months ago (2016-06-01 21:19:08 UTC) #8
kjellander_chromium
On 2016/06/01 21:19:08, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 6 months ago (2016-06-08 10:50:34 UTC) #9
lmilko
On 2016/06/08 10:50:34, kjellander_chromium wrote: > On 2016/06/01 21:19:08, commit-bot: I haz the power wrote: ...
4 years, 6 months ago (2016-06-08 10:56:49 UTC) #10
lmilko
4 years, 6 months ago (2016-06-08 12:57:17 UTC) #11
Message was sent while issue was closed.
On 2016/06/08 10:56:49, lmilko wrote:
> On 2016/06/08 10:50:34, kjellander_chromium wrote:
> > On 2016/06/01 21:19:08, commit-bot: I haz the power wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/867134974146cb103320e398e7544b717bbbc0fe
> > > Cr-Commit-Position: refs/heads/master@{#397246}
> > 
> > Notice that this turns on gold linker for Android MIPS for the GYP build,
but
> > not for GN. Was that intentional?
> > It broke our Android MIPS build for WebRTC, see
> > https://bugs.chromium.org/p/webrtc/issues/detail?id=5977
> 
> Change was not intended for Android, I will upload a fix.

Fix uploaded at https://codereview.chromium.org/2048063002/

Powered by Google App Engine
This is Rietveld 408576698