ui/views/controls/prefix_selector.h - Issue 2027133002: Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/prefix_selector.h

Issue 2027133002: Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor4_up_down_mac

Patch Set: Fix include guard. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/prefix_selector.h

diff --git a/ui/views/controls/prefix_selector.h b/ui/views/controls/prefix_selector.h

index 10fe18b1299ac4e0e8a4244635836150734bcdee..8ee771d534285a4d6231939dfeff9c83072c8e9e 100644

--- a/ui/views/controls/prefix_selector.h

+++ b/ui/views/controls/prefix_selector.h

@@ -55,8 +55,8 @@ class VIEWS_EXPORT PrefixSelector : public ui::TextInputClient {

void ExtendSelectionAndDelete(size_t before, size_t after) override;

void EnsureCaretInRect(const gfx::Rect& rect) override;

- bool IsEditCommandEnabled(int command_id) const override;

- void SetEditCommandForNextKeyEvent(int command_id) override;

+ bool IsEditCommandEnabled(ui::TextEditCommand command) const override;

sky 2016/06/16 17:00:37 Can you rename these? IsTextEditCommandEnabled and

karandeepb 2016/06/17 02:39:03 Done.

+ void SetEditCommandForNextKeyEvent(ui::TextEditCommand command) override;

private:

// Invoked when text is typed. Tries to change the selection appropriately.

« no previous file with comments | « ui/views/cocoa/bridged_content_view.mm ('k') | ui/views/controls/prefix_selector.cc » ('j') | ui/views/controls/textfield/textfield.h » ('J')