content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 2027133002: Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2027133002: Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor4_up_down_mac

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.h ('k') | ui/base/ime/dummy_text_input_client.h » ('j') | ui/base/ime/text_input_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index d4a37c9ad3131209e411bd8d1a2a1bbabe6f6462..a1e8d7faa16cf4e5159965343d95361edf2f7b18 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -1691,12 +1691,13 @@ void RenderWidgetHostViewAura::EnsureCaretInRect(const gfx::Rect& rect) {

ConvertRectFromScreen(intersected_rect));

}

-bool RenderWidgetHostViewAura::IsEditCommandEnabled(int command_id) const {

+bool RenderWidgetHostViewAura::IsEditCommandEnabled(

+ ui::TextEditCommand command) const {

return false;

}

-void RenderWidgetHostViewAura::SetEditCommandForNextKeyEvent(int command_id) {

+void RenderWidgetHostViewAura::SetEditCommandForNextKeyEvent(

+ ui::TextEditCommand command) {}

////////////////////////////////////////////////////////////////////////////////

// RenderWidgetHostViewAura, display::DisplayObserver implementation:

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.h ('k') | ui/base/ime/dummy_text_input_client.h » ('j') | ui/base/ime/text_input_client.h » ('J')