Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2027113002: Make SVGElement::setCursorImageValue take a const pointer (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, chromium-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SVGElement::setCursorImageValue take a const pointer Fix SVGElement::setCursorImageValue() to take a const CSSCursorImageValue* instead of just a regular pointer. This is required pre-work to make StyleBuilderFunctions take const references (since, when calling into SVGElement::setCursorImageValue from StyleBuilderFunctions, only a const pointer is available). BUG=526586 Committed: https://crrev.com/c3dbab87486a0a9b43e45d0d924bc1c6d131d022 Cr-Commit-Position: refs/heads/master@{#397078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/svg/SVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElementRareData.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sashab
4 years, 6 months ago (2016-06-01 06:03:45 UTC) #2
Timothy Loh
On 2016/06/01 06:03:45, sashab wrote: lgtm
4 years, 6 months ago (2016-06-01 06:10:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027113002/1
4 years, 6 months ago (2016-06-01 06:14:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 07:39:02 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 07:40:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3dbab87486a0a9b43e45d0d924bc1c6d131d022
Cr-Commit-Position: refs/heads/master@{#397078}

Powered by Google App Engine
This is Rietveld 408576698