Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2027103002: Fix VulkanOutputSurface build error (Closed)

Created:
4 years, 6 months ago by ssami
Modified:
4 years, 6 months ago
Reviewers:
sohanjg, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix VulkanOutputSurface build error Previous OutputSurface refactor did not consider VulkanOutputSurface. This patch makes it refer to the right OutputSurface constructor. BUG=582558 Committed: https://crrev.com/4fd3883aa8c8238f33a650c60789cb3ca01596a7 Cr-Commit-Position: refs/heads/master@{#399155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ssami
Please take a look
4 years, 6 months ago (2016-06-01 05:42:19 UTC) #2
sohanjg
On 2016/06/01 05:42:19, ssami wrote: > Please take a look looks good. thanks. piman@, dyen@ ...
4 years, 6 months ago (2016-06-01 05:43:45 UTC) #3
sohanjg
piman@, this was broken in the last OS refactor. Can you have a look ?
4 years, 6 months ago (2016-06-07 13:52:04 UTC) #7
piman
lgtm, thanks!
4 years, 6 months ago (2016-06-09 19:31:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027103002/1
4 years, 6 months ago (2016-06-10 10:53:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 11:27:25 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 11:27:30 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 11:29:48 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fd3883aa8c8238f33a650c60789cb3ca01596a7
Cr-Commit-Position: refs/heads/master@{#399155}

Powered by Google App Engine
This is Rietveld 408576698