mus: Initialize WindowManagerConnection in chrome instead of in content.

mus: Initialize WindowManagerConnection in chrome instead of in content.

BUG=none

Committed: https://crrev.com/d2861a3ec3c22eb4b0e1639d6901c45fccfe0678
Cr-Commit-Position: refs/heads/master@{#398242}

[sadrul, 2016-06-01 03:45:41]

sadrul@chromium.org changed reviewers:
+ ben@chromium.org

[sadrul, 2016-06-01 03:45:42]

What do you think of moving the creation of WindowManagerConnection out of
//content into //chrome? This CL moves the initialization into a views-specific
location, which would also make it easier to merge with the ownership change in
https://codereview.chromium.org/2026623002/

[Ben Goodger (Google), 2016-06-01 03:50:13]

On 2016/06/01 03:45:42, sadrul wrote:
> What do you think of moving the creation of WindowManagerConnection out of
> //content into //chrome? This CL moves the initialization into a
views-specific
> location, which would also make it easier to merge with the ownership change
in
> https://codereview.chromium.org/2026623002/

Was there any way mus was used in Content that would break because of this?

[sadrul, 2016-06-01 04:17:15]

On 2016/06/01 03:50:13, Ben Goodger (Google) wrote:
> On 2016/06/01 03:45:42, sadrul wrote:
> > What do you think of moving the creation of WindowManagerConnection out of
> > //content into //chrome? This CL moves the initialization into a
> views-specific
> > location, which would also make it easier to merge with the ownership change
> in
> > https://codereview.chromium.org/2026623002/
> 
> Was there any way mus was used in Content that would break because of this?

--use-mus-in-renderer flag triggers mus-specific code in WebContentsViewMus and
RenderWidgetHostViewMus, but those continue to work after this change. However,
this change means other content embedders would need to explicitly initialize
mus if they want to use mus.

[sadrul, 2016-06-01 05:41:31]

On 2016/06/01 04:17:15, sadrul wrote:
> On 2016/06/01 03:50:13, Ben Goodger (Google) wrote:
> > On 2016/06/01 03:45:42, sadrul wrote:
> > > What do you think of moving the creation of WindowManagerConnection out of
> > > //content into //chrome? This CL moves the initialization into a
> > views-specific
> > > location, which would also make it easier to merge with the ownership
change
> > in
> > > https://codereview.chromium.org/2026623002/
> > 
> > Was there any way mus was used in Content that would break because of this?
> 
> --use-mus-in-renderer flag triggers mus-specific code in WebContentsViewMus
and
> RenderWidgetHostViewMus, but those continue to work after this change.
However,
> this change means other content embedders would need to explicitly initialize
> mus if they want to use mus.

Aha, looks like //services/navigation is a content embedder, so that has to be
updated to explicitly initialize WindowManagerConnection too.

[Ben Goodger (Google), 2016-06-06 18:14:28]

lgtm

[sadrul, 2016-06-06 18:36:36]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-06-06 18:37:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027093002/80001

[commit-bot: I haz the power, 2016-06-06 20:56:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 20:56:07]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sadrul, 2016-06-06 21:40:35]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-06-06 21:41:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027093002/80001

[commit-bot: I haz the power, 2016-06-06 23:21:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 23:21:50]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sadrul, 2016-06-07 02:50:38]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-06-07 02:50:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027093002/80001

[commit-bot: I haz the power, 2016-06-07 05:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 05:23:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sadrul, 2016-06-07 05:40:33]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-06-07 05:40:34]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2027093002/#ps100001
(title: ".")

[commit-bot: I haz the power, 2016-06-07 05:40:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027093002/100001

[commit-bot: I haz the power, 2016-06-07 08:06:06]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-07 08:07:47]

Description was changed from

==========
mus: Initialize WindowManagerConnection in chrome instead of in content.

BUG=none
==========

to

==========
mus: Initialize WindowManagerConnection in chrome instead of in content.

BUG=none

Committed: https://crrev.com/d2861a3ec3c22eb4b0e1639d6901c45fccfe0678
Cr-Commit-Position: refs/heads/master@{#398242}
==========

[commit-bot: I haz the power, 2016-06-07 08:07:49]

Patchset 6 (id:??) landed as
https://crrev.com/d2861a3ec3c22eb4b0e1639d6901c45fccfe0678
Cr-Commit-Position: refs/heads/master@{#398242}