cc : Use transform node data to determine which transform wins at commit

cc : Use transform node data to determine which transform wins at commit

Since the transform tree tracks whether there is a curretly running
transform animation, it can be used to determine whether the local
transform in transform tree node should be overwritten at commit time

BUG=609208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/b9f4613f226aaca4ed11658c42cfacbe5eb48f22
Cr-Commit-Position: refs/heads/master@{#397201}

[jaydasika, 2016-06-01 01:44:04]

Description was changed from

==========
cc : Use transform node data to determine which transform wins at commit

Since the transform tree tracks whether there is a curretly running
transform animation, it can be used to determine whether the local
transform in transform tree node should be overwritten at commit time

BUG=609208
==========

to

==========
cc : Use transform node data to determine which transform wins at commit

Since the transform tree tracks whether there is a curretly running
transform animation, it can be used to determine whether the local
transform in transform tree node should be overwritten at commit time

BUG=609208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-06-01 01:46:51]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-06-01 01:46:52]

PTAL

[ajuma, 2016-06-01 15:14:55]

https://codereview.chromium.org/2027073002/diff/20001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/2027073002/diff/20001/cc/layers/layer_impl.cc...
cc/layers/layer_impl.cc:686:
layer_tree_impl()->AddToTransformAnimationsMap(id(), transform);
I think this needs to happen even when old_transform == transform (just like we
do for opacity), since the old_transform might have been set before the last
commit (that is, the map might have been cleared since then, so if we skip this
step the map won't have a value for this id even though the animation is still
in progress). Please also include this case in the test you added.

[jaydasika, 2016-06-01 16:29:09]

https://codereview.chromium.org/2027073002/diff/20001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/2027073002/diff/20001/cc/layers/layer_impl.cc...
cc/layers/layer_impl.cc:686:
layer_tree_impl()->AddToTransformAnimationsMap(id(), transform);
On 2016/06/01 15:14:55, ajuma wrote:
> I think this needs to happen even when old_transform == transform (just like
we
> do for opacity), since the old_transform might have been set before the last
> commit (that is, the map might have been cleared since then, so if we skip
this
> step the map won't have a value for this id even though the animation is still
> in progress). Please also include this case in the test you added.

Done.

[ajuma, 2016-06-01 17:07:18]

Thanks, lgtm

[jaydasika, 2016-06-01 18:46:31]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-06-01 18:46:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027073002/40001

[commit-bot: I haz the power, 2016-06-01 19:18:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-01 19:20:12]

Description was changed from

==========
cc : Use transform node data to determine which transform wins at commit

Since the transform tree tracks whether there is a curretly running
transform animation, it can be used to determine whether the local
transform in transform tree node should be overwritten at commit time

BUG=609208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Use transform node data to determine which transform wins at commit

Since the transform tree tracks whether there is a curretly running
transform animation, it can be used to determine whether the local
transform in transform tree node should be overwritten at commit time

BUG=609208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/b9f4613f226aaca4ed11658c42cfacbe5eb48f22
Cr-Commit-Position: refs/heads/master@{#397201}
==========

[commit-bot: I haz the power, 2016-06-01 19:20:13]

Patchset 3 (id:??) landed as
https://crrev.com/b9f4613f226aaca4ed11658c42cfacbe5eb48f22
Cr-Commit-Position: refs/heads/master@{#397201}