Move Windows build output from //build to //out

Move Windows build output from //build to //out

This is needed in order to begin migration to GN because
third-party dependencies and GN boilerplate expect GN
boilerplate to be in //build.

R=asiva@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/44796ed02de074c6becedc8525890e3ac166a949

[zra, 2016-06-01 17:14:12]

Description was changed from

==========
Move Windows build output from //build to //out
==========

to

==========
Move Windows build output from //build to //out

This is needed in order to begin migration to GN because
third-party dependencies and GN boilerplate expect GN
boilerplate to be in //build.
==========

[zra, 2016-06-01 17:17:09]

zra@google.com changed reviewers:
+ asiva@google.com, whesse@google.com

[zra, 2016-06-01 17:17:10]

@whesse can you think of any other places this is hard-coded in?

[Bill Hesse, 2016-06-01 17:36:28]

On 2016/06/01 17:17:10, zra wrote:
> @whesse can you think of any other places this is hard-coded in?

Offhand, I would check the create_sdk target and scripts, and the windows
dartium build.  You could commit an experimental branch and run it on the
dartium builder and the sdk builder.

[zra, 2016-06-01 17:51:36]

On 2016/06/01 17:36:28, Bill Hesse wrote:
> You could commit an experimental branch and run it on the
> dartium builder and the sdk builder.

Are there instructions for doing this somewhere? I haven't done this before and
it sounds like it could be bad to mess up.

[zra, 2016-06-01 18:02:37]

On 2016/06/01 17:51:36, zra wrote:
> On 2016/06/01 17:36:28, Bill Hesse wrote:
> > You could commit an experimental branch and run it on the
> > dartium builder and the sdk builder.
> 
> Are there instructions for doing this somewhere? I haven't done this before
and
> it sounds like it could be bad to mess up.

The create_sdk target worked locally without any additional changes.

[siva, 2016-06-01 18:30:45]

asiva@google.com changed reviewers:
+ terry@google.com

[siva, 2016-06-01 18:30:45]

LGTM

Adding @terry, he should be able to tell if the dartium win build will break
because of this.

[zra, 2016-06-02 15:52:27]

On 2016/06/01 18:30:45, siva wrote:
> Adding @terry, he should be able to tell if the dartium win build will break
> because of this.

@terry Do you know if this will cause any problems for the Windows Dartium
build? Thanks!

[Bill Hesse, 2016-06-02 16:23:03]

On 2016/06/02 15:52:27, zra wrote:
> On 2016/06/01 18:30:45, siva wrote:
> > Adding @terry, he should be able to tell if the dartium win build will break
> > because of this.
> 
> @terry Do you know if this will cause any problems for the Windows Dartium
> build? Thanks!

I will run this CL on our dartium builders.  Also, we do ninja builds on
Windows, too, I think.  So do we need to change something other than
configurations_msvs.gypi to affect the ninja build?  I can test this as well.

[zra, 2016-06-02 16:50:28]

On 2016/06/02 16:23:03, Bill Hesse wrote:
> On 2016/06/02 15:52:27, zra wrote:
> > On 2016/06/01 18:30:45, siva wrote:
> > > Adding @terry, he should be able to tell if the dartium win build will
break
> > > because of this.
> > 
> > @terry Do you know if this will cause any problems for the Windows Dartium
> > build? Thanks!
> 
> I will run this CL on our dartium builders.  Also, we do ninja builds on
> Windows, too, I think.  So do we need to change something other than
> configurations_msvs.gypi to affect the ninja build?  I can test this as well.

Thanks! The .ninja build files are also generated by gyp for the ninja build, so
unless there is some inconsistency between the gyp backends, I expect ninja to
be okay.

[Bill Hesse, 2016-06-02 19:27:41]

LGTM.  The dartium and sdk builders worked fine, with the build directory
clobbered.

[zra, 2016-06-03 15:28:52]

Description was changed from

==========
Move Windows build output from //build to //out

This is needed in order to begin migration to GN because
third-party dependencies and GN boilerplate expect GN
boilerplate to be in //build.
==========

to

==========
Move Windows build output from //build to //out

This is needed in order to begin migration to GN because
third-party dependencies and GN boilerplate expect GN
boilerplate to be in //build.

R=asiva@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/44796ed02de074c6becedc8525890e3ac166a949
==========

[zra, 2016-06-03 15:28:54]

Committed patchset #1 (id:1) manually as
44796ed02de074c6becedc8525890e3ac166a949 (presubmit successful).

[Johnni Winther, 2016-06-06 10:54:33]

On 2016/06/03 15:28:54, zra wrote:
> Committed patchset #1 (id:1) manually as
> 44796ed02de074c6becedc8525890e3ac166a949 (presubmit successful).

Has this been tested? .bat files in sdk/bin/ still refer to the 'build' folder
and my Windows system seems arbitrarily broken if the old build folder is
removed (dart2js tests crashing with 'The system cannot find the path
specified.')

[zra, 2016-06-06 12:57:58]

On 2016/06/06 10:54:33, Johnni Winther wrote:
> On 2016/06/03 15:28:54, zra wrote:
> > Committed patchset #1 (id:1) manually as
> > 44796ed02de074c6becedc8525890e3ac166a949 (presubmit successful).
> 
> Has this been tested? .bat files in sdk/bin/ still refer to the 'build' folder
> and my Windows system seems arbitrarily broken if the old build folder is
> removed (dart2js tests crashing with 'The system cannot find the path
> specified.')

The .bat files should be updated, but if no tests use them, it's likely that
they will break again. This change was tested locally, and the bots have been
green since it landed. I inspected the failures currently on the Windows dart2js
bot, and they are unrelated to this change.