Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2027013002: aw: Fix testForceDrawWhenInvisible (Closed)

Created:
4 years, 6 months ago by boliu
Modified:
4 years, 6 months ago
Reviewers:
hush (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Fix testForceDrawWhenInvisible Use view size rather than content size, since content size might still be empty before draw. BUG=615184 Committed: https://crrev.com/c53cb19c99a47490a6d5b4d44c35ef256ca4eac2 Cr-Commit-Position: refs/heads/master@{#397014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java View 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
boliu
ptal
4 years, 6 months ago (2016-05-31 23:26:00 UTC) #2
hush (inactive)
lgtm seems like the visual state callback does not guarantee the contentWidth/HeightCss to be non-zero ...
4 years, 6 months ago (2016-05-31 23:59:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027013002/1
4 years, 6 months ago (2016-06-01 00:05:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 01:24:20 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 01:26:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c53cb19c99a47490a6d5b4d44c35ef256ca4eac2
Cr-Commit-Position: refs/heads/master@{#397014}

Powered by Google App Engine
This is Rietveld 408576698