Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issue 2027003002: [builtins] Migrate escape/unescape from uri.js to C++. (Closed)

Created:
4 years, 6 months ago by Franzi
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate escape/unescape from uri.js to C++. These functions call into C++ anyways, so there's no need to have the JavaScript wrapper around them. This commit removes uri.js completely. R=yangguo@chromium.org, bmeurer@chromium.org BUG=v8:4912 Committed: https://crrev.com/0f06f80f6ff361ab9a064d30221837cd54d38998 Cr-Commit-Position: refs/heads/master@{#36629}

Patch Set 1 #

Patch Set 2 : Minor refactoring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -353 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
D src/js/uri.js View 1 chunk +0 lines, -37 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +1 line, -7 lines 0 comments Download
D src/runtime/runtime-uri.cc View 1 chunk +0 lines, -289 lines 0 comments Download
M src/uri.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/uri.cc View 1 7 chunks +216 lines, -16 lines 0 comments Download
M src/v8.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Franzi
Hi, I deleted uri.js, since the remaining two functions escape/unescape were already calling C++ runtime ...
4 years, 6 months ago (2016-06-01 03:46:16 UTC) #1
Benedikt Meurer
Awesome, thanks! LGTM.
4 years, 6 months ago (2016-06-01 03:49:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027003002/20001
4 years, 6 months ago (2016-06-01 03:58:45 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 04:24:43 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 04:26:45 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f06f80f6ff361ab9a064d30221837cd54d38998
Cr-Commit-Position: refs/heads/master@{#36629}

Powered by Google App Engine
This is Rietveld 408576698