Remove FXJSE_Value_ToObject and call methods directly

xfa/fxfa/parser/xfa_script.h

Index: xfa/fxfa/parser/xfa_script.h
diff --git a/xfa/fxfa/parser/xfa_script.h b/xfa/fxfa/parser/xfa_script.h
index da348f7a36fb0a62139cfee2c59c288561cb825d..23390332045f1fb0ea83c68052c9c8231c37b2fd 100644
--- a/xfa/fxfa/parser/xfa_script.h
+++ b/xfa/fxfa/parser/xfa_script.h
@@ -41,16 +41,13 @@ class CXFA_ValueArray : public CFX_ArrayTemplate<CFXJSE_Value*> {
   CXFA_ValueArray(v8::Isolate* pIsolate) : m_pIsolate(pIsolate) {}

[Tom Sepez, 2016/06/02 18:20:23]

nit: explicit

[dsinclair, 2016/06/02 18:58:05]

Done.

 
   ~CXFA_ValueArray() {
-    for (int32_t i = 0; i < GetSize(); i++) {
+    for (int32_t i = 0; i < GetSize(); i++)
       delete GetAt(i);
-    }
   }
 
   void GetAttributeObject(CXFA_ObjArray& objArray) {
-    for (int32_t i = 0; i < GetSize(); i++) {
-      objArray.Add(
-          static_cast<CXFA_Object*>(FXJSE_Value_ToObject(GetAt(i), nullptr)));
-    }
+    for (int32_t i = 0; i < GetSize(); i++)
+      objArray.Add(static_cast<CXFA_Object*>(GetAt(i)->ToHostObject(nullptr)));

[dsinclair, 2016/06/02 15:27:52]

Can't use CXFA_ScriptContext::ToObject here because the includes become
circular.

[Tom Sepez, 2016/06/02 18:20:22]

That's usually a sign that the implementation should be in the .cpp file.

[dsinclair, 2016/06/02 18:58:05]

Done.

   }
 
   v8::Isolate* m_pIsolate;