xfa/fxfa/app/xfa_ffdochandler.cpp - Issue 2026993003: Remove FXJSE_Value_ToObject and call methods directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_ffdochandler.cpp

Issue 2026993003: Remove FXJSE_Value_ToObject and call methods directly (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@context_cleanup_3

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/app/xfa_ffdochandler.cpp

diff --git a/xfa/fxfa/app/xfa_ffdochandler.cpp b/xfa/fxfa/app/xfa_ffdochandler.cpp

index e65dd914d167326c0405757f90f2112ddee5be4a..bd99b5dd58849496e4a59c0553f79d6823ec50c6 100644

--- a/xfa/fxfa/app/xfa_ffdochandler.cpp

+++ b/xfa/fxfa/app/xfa_ffdochandler.cpp

@@ -56,7 +56,5 @@ FX_BOOL CXFA_FFDocHandler::RunDocScript(CXFA_FFDoc* hDoc,

return pScriptContext->RunScript(

(XFA_SCRIPTLANGTYPE)eScriptType, wsScript, pRetValue,

- pThisValue

- ? static_cast<CXFA_Object*>(FXJSE_Value_ToObject(pThisValue, nullptr))

- : nullptr);

+ pThisValue ? pThisValue->ToObject(nullptr) : nullptr);

}

« no previous file with comments | « no previous file | xfa/fxfa/fm2js/xfa_fm2jscontext.cpp » ('j') | xfa/fxfa/fm2js/xfa_fm2jscontext.cpp » ('J')