Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: xfa/fxfa/app/xfa_ffdochandler.cpp

Issue 2026993003: Remove FXJSE_Value_ToObject and call methods directly (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@context_cleanup_3
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa.gyp ('k') | xfa/fxfa/fm2js/xfa_fm2jscontext.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxfa/include/xfa_ffdochandler.h" 7 #include "xfa/fxfa/include/xfa_ffdochandler.h"
8 8
9 #include "xfa/fxfa/include/xfa_checksum.h" 9 #include "xfa/fxfa/include/xfa_checksum.h"
10 #include "xfa/fxfa/include/xfa_ffdoc.h" 10 #include "xfa/fxfa/include/xfa_ffdoc.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 CXFA_Document* pXFADoc = hDoc->GetXFADoc(); 49 CXFA_Document* pXFADoc = hDoc->GetXFADoc();
50 if (!pXFADoc) 50 if (!pXFADoc)
51 return FALSE; 51 return FALSE;
52 52
53 CXFA_ScriptContext* pScriptContext = pXFADoc->GetScriptContext(); 53 CXFA_ScriptContext* pScriptContext = pXFADoc->GetScriptContext();
54 if (!pScriptContext) 54 if (!pScriptContext)
55 return FALSE; 55 return FALSE;
56 56
57 return pScriptContext->RunScript( 57 return pScriptContext->RunScript(
58 (XFA_SCRIPTLANGTYPE)eScriptType, wsScript, pRetValue, 58 (XFA_SCRIPTLANGTYPE)eScriptType, wsScript, pRetValue,
59 pThisValue 59 pThisValue ? CXFA_ScriptContext::ToObject(pThisValue, nullptr) : nullptr);
60 ? static_cast<CXFA_Object*>(FXJSE_Value_ToObject(pThisValue, nullptr))
61 : nullptr);
62 } 60 }
OLDNEW
« no previous file with comments | « xfa.gyp ('k') | xfa/fxfa/fm2js/xfa_fm2jscontext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698