xfa/fxfa/parser/cxfa_valuearray.h - Issue 2026993003: Remove FXJSE_Value_ToObject and call methods directly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/fxfa/parser/cxfa_valuearray.h

Issue 2026993003: Remove FXJSE_Value_ToObject and call methods directly (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@context_cleanup_3

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 PDFium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

	6

	7 #ifndef XFA_FXFA_PARSER_CXFA_VALUEARRAY_H_

	8 #define XFA_FXFA_PARSER_CXFA_VALUEARRAY_H_

	9

	10 #include "xfa/fxfa/include/fxfa.h"

	11 #include "xfa/fxjse/value.h"

	12

	13 class CXFA_ValueArray : public CFX_ArrayTemplate<CFXJSE_Value*> {

	14 public:

	15 explicit CXFA_ValueArray(v8::Isolate* pIsolate);

	16 ~CXFA_ValueArray();

	17

	18 void GetAttributeObject(CXFA_ObjArray& objArray);

	19

	20 v8::Isolate* m_pIsolate;
	Tom Sepez 2016/06/02 20:42:18 nit: can this be v8::Isolate* const m_pIsolate; ? nit: can this be v8::Isolate* const m_pIsolate; ? dsinclair 2016/06/03 00:35:16 Done. Show quoted text On 2016/06/02 20:42:18, Tom Sepez wrote: > nit: can this be v8::Isolate* const m_pIsolate; ? Done.
	21 };

	22

	23 #endif // XFA_FXFA_PARSER_CXFA_VALUEARRAY_H_

OLD	NEW

« no previous file with comments | « xfa/fxfa/fm2js/xfa_fm2jscontext.cpp ('k') | xfa/fxfa/parser/cxfa_valuearray.cpp » ('j') | no next file with comments »