Remove FXJSE_Value_ToObject and call methods directly

xfa/fxjse/value.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxjse/value.h"
 
 #include <math.h>
 
+#include "xfa/fxfa/fm2js/xfa_fm2jscontext.h"

[Tom Sepez, 2016/06/01 20:17:58]

illegal include, in theory due to layering.

 #include "xfa/fxjse/class.h"
 #include "xfa/fxjse/context.h"
 
 FX_BOOL FXJSE_Value_IsUndefined(CFXJSE_Value* pValue) {
   return pValue && pValue->IsUndefined();
 }
 
 FX_BOOL FXJSE_Value_IsNull(CFXJSE_Value* pValue) {
   return pValue && pValue->IsNull();
 }
@@ skipping 36 matching lines @@
 
 void FXJSE_Value_ToUTF8String(CFXJSE_Value* pValue,
                               CFX_ByteString& szStrOutput) {
   pValue->ToString(szStrOutput);
 }
 
 int32_t FXJSE_Value_ToInteger(CFXJSE_Value* pValue) {
   return pValue->ToInteger();
 }
 
-CFXJSE_HostObject* FXJSE_Value_ToObject(CFXJSE_Value* pValue,
-                                        CFXJSE_Class* pClass) {
-  return pValue->ToObject(pClass);
-}
-
 void FXJSE_Value_SetUndefined(CFXJSE_Value* pValue) {
   pValue->SetUndefined();
 }
 
 void FXJSE_Value_SetNull(CFXJSE_Value* pValue) {
   pValue->SetNull();
 }
 
 void FXJSE_Value_SetBoolean(CFXJSE_Value* pValue, FX_BOOL bBoolean) {
   pValue->SetBoolean(bBoolean);
@@ skipping 109 matching lines @@
       hError.As<v8::Object>()->Set(
           v8::String::NewFromUtf8(pIsolate, "name"),
           v8::String::NewFromUtf8(pIsolate, utf8Name.c_str(),
                                   v8::String::kNormalString,
                                   utf8Name.GetLength()));
     }
   }
   pIsolate->ThrowException(hError);
 }
 
-CFXJSE_HostObject* CFXJSE_Value::ToObject(CFXJSE_Class* lpClass) const {
+CFXJSE_HostObject* CFXJSE_Value::ToHostObject(CFXJSE_Class* lpClass) const {
   ASSERT(!m_hValue.IsEmpty());
 
   CFXJSE_ScopeUtil_IsolateHandleRootContext scope(m_pIsolate);
   v8::Local<v8::Value> pValue = v8::Local<v8::Value>::New(m_pIsolate, m_hValue);
   ASSERT(!pValue.IsEmpty());
 
   if (!pValue->IsObject())
     return nullptr;
 
   return FXJSE_RetrieveObjectBinding(pValue.As<v8::Object>(), lpClass);
 }
 
+CXFA_Object* CFXJSE_Value::ToObject(CFXJSE_Class* lpClass) const {
+  return static_cast<CXFA_Object*>(ToHostObject(lpClass));
+}
+
+CXFA_Node* CFXJSE_Value::ToNode(CFXJSE_Class* lpClass) const {
+  return static_cast<CXFA_Node*>(ToHostObject(lpClass));
+}
+
+CXFA_FM2JSContext* CFXJSE_Value::ToJSContext(CFXJSE_Class* lpClass) const {
+  return static_cast<CXFA_FM2JSContext*>(ToHostObject(lpClass));
+}
+
+CXFA_ThisProxy* CFXJSE_Value::ToProxy(CFXJSE_Class* lpClass) const {
+  return static_cast<CXFA_ThisProxy*>(ToHostObject(lpClass));
+}
+
 V8_INLINE static double FXJSE_ftod(FX_FLOAT fNumber) {
   if (sizeof(FX_FLOAT) != 4) {
     ASSERT(FALSE);
     return fNumber;
   }
 
   uint32_t nFloatBits = (uint32_t&)fNumber;
   uint8_t nExponent = (uint8_t)(nFloatBits >> 16 >> 7);
   if (nExponent == 0 || nExponent == 255)
     return fNumber;
@@ skipping 270 matching lines @@
   if (lpRetValue)
     lpRetValue->ForceSetValue(hReturnValue);
 
   if (lpLocalArgs) {
     for (uint32_t i = 0; i < nArgCount; i++)
       lpLocalArgs[i].~Local();
     FX_Free(lpLocalArgs);
   }
   return bRetValue;
 }