Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2026983003: Build Engine with symbol_level = 1 to get line numbers in crash reports (Closed)

Created:
4 years, 6 months ago by maniscalco
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build Engine with symbol_level = 1 to get line numbers in crash reports TEST=See bug for details on how this was tested. BUG=616237 Committed: https://crrev.com/4b0c15cc18e8930d5959376d075c6d9672613218 Cr-Commit-Position: refs/heads/master@{#397013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M build/args/bots/official.desktop/blimp-engine.gn View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
maniscalco
4 years, 6 months ago (2016-05-31 23:03:14 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-05-31 23:17:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026983003/1
4 years, 6 months ago (2016-05-31 23:24:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 01:23:52 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 01:26:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b0c15cc18e8930d5959376d075c6d9672613218
Cr-Commit-Position: refs/heads/master@{#397013}

Powered by Google App Engine
This is Rietveld 408576698